-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path.data does not accept the legacy format with a comma-separated list for MDP anymore #76181
Comments
As a sidenote, this configuration format was once a recommended workaround: https://www.elastic.co/blog/multi-data-path-bug-in-elasticsearch-5-3-0 |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
MDP still works if using the (newer?) config notation:
but still, this seems to be a regression between 7.13.4 and 7.14.0. |
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes elastic#76181
Can't believe this kind of changes makes it to stable. Breaks infra on upgrade/install because in comma mode ( |
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes #76181
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes #76181
I am experiencing the same problem, but I am using docker-compose.yml to supply the path.data definition, and the recommended YAML config for elasticsearch.yml won't work for me. I would greatly appreciate it if someone could supply a syntactically correct way to define this in docker-compose.yml. |
If you're using a docker configuration then any entries underneath an
Also double check your spacing is correct when you update your configuration, especially indent/nesting levels/preceding spaces, as per standard yaml editing fun. |
Thanks, geekpete, I was given similar info by Elastic support and my cluster is now back up and operational. I am not happy that this bug made it through testing, but I was very happy with Elastic's responsiveness and professionalism in finding the solution. I suffered no permanent data loss. Can't have a better outcome than that! Not so happy that I have to reconfigure my servers so I can't take advantage of distributing my I/O across my NVMe SSDs, but I can understand the reasons behind the multi data path feature being deprecated. |
This issue was fixed by #76202 and should be out in 7.14.1 |
Just rolled out 7.14.1, everything works as expected again. Thanks! |
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes elastic#76181
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes #76181
Elasticsearch version:
Version: 7.14.0, Build: default/deb/dd5a0a2acaa2045ff9624f3729fc8a6f40835aa1/2021-07-29T20:49:32.864135063Z, JVM: 16.0.1
JVM version:
openjdk version "11.0.12" 2021-07-20
OpenJDK Runtime Environment (build 11.0.12+7-post-Debian-2deb10u1)
OpenJDK 64-Bit Server VM (build 11.0.12+7-post-Debian-2deb10u1, mixed mode, sharing)
OS version:
4.19.0-14-amd64 #1 SMP Debian 4.19.171-2 (2021-01-30) x86_64 GNU/Linux
Description of the problem including expected versus actual behavior:
We upgraded a cluster from 7.13.4 to 7.14.0. This cluster still uses the deprecated MDP path.data-feature and the old config format using just a comma-separated list as config value for path.data
Restarting under 7.14.0 yields just one data dir, not both as under 7.13.4.
The text was updated successfully, but these errors were encountered: