Fix path.data as comma separated string #76202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes elastic#76181
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
gwbrown
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
LGTM.
It occurs to me that with this change (and, presumably, the previous behavior) we can't handle data paths with commas in the name like /var/stuff/elastic,search, despite that being a perfectly valid path on at least MacOS and Linux (not sure about Windows). Not that I've ever actually seen a path like that in practice.
rjernst
added
the
auto-backport
rjernst
added a commit
that referenced
this pull request
Aug 13, 2021
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes #76181
17 tasks
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 15, 2021
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes elastic#76181
rjernst
added a commit
that referenced
this pull request
Oct 18, 2021
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes #76181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multiple data paths, there are several allowed varieties of
specifcying the paths. The yaml list forms, both single and multi line,
are allowed, but another form is a string containing commas that is
parsed as a list. This latter form was broken recently by the
refactoring of path.data parsing to emit deprecation warnings for MDP.
This commit fixes the comma separated string case and adds a test.
closes #76181