REST high-level client: add force merge API #28896
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@elasticmachine ok to test |
| assertThat(request.getEndpoint(), equalTo(endpoint.toString())); | ||
| assertThat(request.getParameters(), equalTo(expectedParams)); | ||
| assertThat(request.getEntity(), nullValue()); | ||
| assertThat(request.getMethod(), equalTo(HttpPost.METHOD_NAME)); |
There was a problem hiding this comment.
can you add a test for the case when indices are not set or set to null? I found also in the clear cache PR that things break :) (also with refresh and flush)
There was a problem hiding this comment.
Hi @javanna, when indices are not set or set to null, we need to do operations on all the indices ? or throw an exception ? According to our docs it should be the former ? But I see currently if we didn't set indices (null), we will get an exception when we build the endpoint here, shall we need to modify it ?
There was a problem hiding this comment.
we should use the endpoint that requires no indices (e.g. /_forcemerge), the server will expand that to all indices.
| * This class works well for object that do have a constructor argument or that can be built using information available from earlier in the | ||
| * XContent. For objects that have constructors with required arguments that are specified on the same level as other fields see | ||
| * This class works well for object that doesn't have a constructor argument or that can be built using information available from earlier | ||
| * in the XContent. For objects that have constructors with required arguments that are specified on the same level as other fields see |
There was a problem hiding this comment.
could you leave this change out please? I don't exactly understand these docs, so maybe we can try and fix them separately and give such change more visibility.
There was a problem hiding this comment.
Okay, I'll remove it here. I just find this when I read the docs of ObjectParser/ConstructingObjectParser :) because I feel like it seems a typo ? To say ConstructingObjectParser is to construct object which has a constructor with arguments, and ObjectParser is rather for object has a constructor without arguments, so we need to set its fields by declaring other methods (ex. setter) ?
|
@javanna I updated the 2 PRs. |
| } | ||
| { | ||
| ForceMergeRequest forceMergeRequestAll = new ForceMergeRequest(); | ||
| Map<String, String> expectedParams = new HashMap<>(); |
There was a problem hiding this comment.
This test case seems the same as the one above L586-L612 when the randomIndicesNames(0, 5) returned an empty array ( in BroadcastRequest.java : protected String[] indices = Strings.EMPTY_ARRAY ).
|
thanks again @PnPie, and sorry about the radio silence. I just merged master in as there were conflicts, I will merge as soon as I get a green build. |
|
retest this please |
|
retest this please |
* es/master: (27 commits) [Docs] Add rank_eval size parameter k (#29218) [DOCS] Remove ignore_z_value parameter link Docs: Update docs/index_.asciidoc (#29172) Docs: Link C++ client lib elasticlient (#28949) [DOCS] Unregister repository instead of deleting it (#29206) Docs: HighLevelRestClient#multiSearch (#29144) Add Z value support to geo_shape Remove type casts in logging in server component (#28807) Change BroadcastResponse from ToXContentFragment to ToXContentObject (#28878) REST : Split `RestUpgradeAction` into two actions (#29124) Add error file docs to important settings Add note to low-level client docs for DNS caching (#29213) Harden periodically check to avoid endless flush loop (#29125) Remove deprecated options for query_string (#29203) REST high-level client: add force merge API (#28896) Remove license information from README.textile (#29198) Decouple more classes from XContentBuilder and make builder strict (#29197) [Docs] Fix missing closing block in cluster/misc.asciidoc RankEvalRequest should implement IndicesRequest (#29188) Use EnumMap in ClusterBlocks (#29112) ...
* es/6.x: (29 commits) [Docs] Add rank_eval size parameter k (#29218) Docs: Update docs/index_.asciidoc (#29172) Docs: Link C++ client lib elasticlient (#28949) Docs: HighLevelRestClient#multiSearch (#29144) [DOCS] Remove ignore_z_value parameter link Add Z value support to geo_shape Change BroadcastResponse from ToXContentFragment to ToXContentObject (#28878) REST : Split `RestUpgradeAction` into two actions (#29124) [DOCS] Unregister repository instead of deleting it (#29206) Remove type casts in logging in server component (#28807) Add error file docs to important settings Add note to low-level client docs for DNS caching (#29213) testShrinkAfterUpgrade should only set mapping.single_type if bwc version > 5.5.0 Harden periodically check to avoid endless flush loop (#29125) REST high-level client: add force merge API (#28896) Remove license information from README.textile (#29198) Decouple more classes from XContentBuilder and make builder strict (#29197) Propagate mapping.single_type setting on shrinked index (#29202) [Docs] Fix missing closing block in cluster/misc.asciidoc RankEvalRequest should implement IndicesRequest (#29188) ...
Force Merge xD.
Relates to #27205