Remove deprecated options for query_string #29203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes some parameters deprecated in 6.x (or 5.x): `use_dismax`, `split_on_whitespace`, `all_fields` and `lowercase_expanded_terms`. Closes elastic#25551
jimczi
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search-aggs |
|
Should this not have a breaking label since it does break the API. I know the parameters were ignored before but they were accepted when we are parsing which they now won't be so I think its worth having this change in the release notes so people can see that they might need to change their client code? |
|
Thanks @colings86 , I added the breaking label. |
colings86
approved these changes
Mar 22, 2018
| @@ -78,15 +78,9 @@ | |||
| private static final ParseField ANALYZER_FIELD = new ParseField("analyzer"); | |||
| private static final ParseField QUOTE_ANALYZER_FIELD = new ParseField("quote_analyzer"); | |||
| private static final ParseField ALLOW_LEADING_WILDCARD_FIELD = new ParseField("allow_leading_wildcard"); | |||
| private static final ParseField AUTO_GENERATE_PHRASE_QUERIES_FIELD = new ParseField("auto_generate_phrase_queries") | |||
| .withAllDeprecated("This setting is ignored, use [type=phrase] instead"); | |||
There was a problem hiding this comment.
I think we should add this to the breaking changes doc above?
| @@ -97,13 +91,7 @@ | |||
| private static final ParseField MINIMUM_SHOULD_MATCH_FIELD = new ParseField("minimum_should_match"); | |||
| private static final ParseField QUOTE_FIELD_SUFFIX_FIELD = new ParseField("quote_field_suffix"); | |||
| private static final ParseField LENIENT_FIELD = new ParseField("lenient"); | |||
| private static final ParseField LOCALE_FIELD = new ParseField("locale") | |||
| .withAllDeprecated("Decision is now made by the analyzer"); | |||
There was a problem hiding this comment.
I think we should add this to the breaking changes doc above?
martijnvg
added a commit
that referenced
this pull request
Mar 26, 2018
* es/master: (27 commits) [Docs] Add rank_eval size parameter k (#29218) [DOCS] Remove ignore_z_value parameter link Docs: Update docs/index_.asciidoc (#29172) Docs: Link C++ client lib elasticlient (#28949) [DOCS] Unregister repository instead of deleting it (#29206) Docs: HighLevelRestClient#multiSearch (#29144) Add Z value support to geo_shape Remove type casts in logging in server component (#28807) Change BroadcastResponse from ToXContentFragment to ToXContentObject (#28878) REST : Split `RestUpgradeAction` into two actions (#29124) Add error file docs to important settings Add note to low-level client docs for DNS caching (#29213) Harden periodically check to avoid endless flush loop (#29125) Remove deprecated options for query_string (#29203) REST high-level client: add force merge API (#28896) Remove license information from README.textile (#29198) Decouple more classes from XContentBuilder and make builder strict (#29197) [Docs] Fix missing closing block in cluster/misc.asciidoc RankEvalRequest should implement IndicesRequest (#29188) Use EnumMap in ClusterBlocks (#29112) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some parameters deprecated in 6.x (or 5.x):
use_dismax,split_on_whitespace,all_fieldsandlowercase_expanded_terms.Closes #25551