Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types from client-benchmark-noop-api-plugin URLs #46668

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Remove types from client-benchmark-noop-api-plugin URLs #46668

merged 2 commits into from
Sep 20, 2019

Conversation

romseygeek
Copy link
Contributor

Part of #41059

@romseygeek romseygeek added :Delivery/Build Build or test infrastructure >refactoring v8.0.0 labels Sep 12, 2019
@romseygeek romseygeek self-assigned this Sep 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@romseygeek
Copy link
Contributor Author

I haven't marked this as >breaking even though it's changing a URL because as far as I can tell this plugin is only used internally and isn't shipped as part of a distribution.

danielmitterdorfer
danielmitterdorfer approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@romseygeek
Copy link
Contributor Author

@elasticmachine please test this

@romseygeek
Copy link
Contributor Author

@elasticmachine test this please

1 similar comment
@romseygeek
Copy link
Contributor Author

@elasticmachine test this please

@romseygeek
Copy link
Contributor Author

@elasticmachine upgrade branch

@romseygeek
Copy link
Contributor Author

@elasticmachine update branch

@romseygeek romseygeek merged commit 42bf8a0 into elastic:master Sep 20, 2019
@romseygeek romseygeek deleted the types-removal/noop-search-action branch September 20, 2019 13:28
@jpountz jpountz mentioned this pull request Sep 20, 2019
Closed
66 tasks
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
Closed
66 tasks
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees

@romseygeek romseygeek

Labels
:Delivery/Build Build or test infrastructure >refactoring Team:Delivery Meta label for Delivery team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romseygeek @elasticmachine @danielmitterdorfer @jakelandis @mark-vieira