Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types removal - compatible changes #54160

Closed
43 of 66 tasks
pgomulka opened this issue Mar 25, 2020 · 3 comments
Closed
43 of 66 tasks

Types removal - compatible changes #54160

pgomulka opened this issue Mar 25, 2020 · 3 comments
Assignees
@pgomulka
Labels
Meta v8.0.0-alpha2

Comments

@pgomulka
Copy link
Contributor

pgomulka commented Mar 25, 2020 •
edited
Loading

This issue is meant to track progress on types removal compatible changes. It is a copy of a #41059 where types removal was tracked.
This is a meta issue that tracks things that must or should be done before 8.0 in order to finalize the removal of types.
relates: the main meta issue
MUST

SHOULD

KNOWN BUGS/ TRAPS

Remaining:

Longer term:
@pgomulka pgomulka self-assigned this Mar 25, 2020
@pgomulka pgomulka mentioned this issue Mar 30, 2020
Merged
pgomulka added a commit that referenced this issue Apr 28, 2020
@pgomulka
Compatible logic for include_type_param and RestCreateIndexAction (#5…
3a8303e 
…4197)

Refactoring of the compatible infrastructure to allow registering multiple RestAction under the same path. It only extends the current mechanism which allowed registering RestAction under the same path but with different method. Now it also uses a version together with a method to find a matching RestAction

This PR also provides a V7 compatible RestCreateIndexAction that needs include_Type_param and a different logic for parsing mapping from its body.

fixed get/index tests
CompatRestIT. test {yaml=get/21_stored_fields_with_types/Stored fields}
CompatRestIT. test {yaml=get/71_source_filtering_with_types/Source
filtering}

CompatRestIT. test {yaml=index/70_mix_typeless_typeful/Index call that
introduces new field mappings}
CompatRestIT. test {yaml=index/70_mix_typeless_typeful/Index with
typeless API on an index that has types}

however the last one from get is still failing
CompatRestIT. test {yaml=get/100_mix_typeless_typeful/GET with typeless
API on an index that has

relates #54160
@pgomulka pgomulka mentioned this issue Jun 17, 2020
Merged
pgomulka added a commit that referenced this issue Jul 14, 2020
@pgomulka
Compatible Delete and Update rest actions (#58246)
e457a92 
based on compat/search branch

fixed tests from delete and update directories.
Delete test is still not fixed
CompatRestIT. test {yaml=delete/70_mix_typeless_typeful/DELETE with typeless API on an index that has types}

current state
1306tests | 174failures

previously
1306tests | 197failures

relates #54160
@syedsouban
Copy link

syedsouban commented Jul 19, 2020 •
edited
Loading

Hi, I use elasticsearch at work and I love it wanted to learn more about elasticsearch so I thought of contributing to it. I was thinking if there are issues which I can work on as a new contributor. Thanks!

@pgomulka
Copy link
Contributor Author

@syedsouban thank you for your interest in contributing to Elasticsearch. Have a look into these issues for the work that might be good for new contributors. good first issue low hanging fruit

@pgomulka pgomulka mentioned this issue Feb 11, 2021
Closed
@pgomulka pgomulka mentioned this issue Feb 25, 2021
Merged
pgomulka added a commit that referenced this issue Mar 23, 2021
@pgomulka
[REST Compatible API] Typed endpoints for Index and Get APIs (#69131)
e942873 
The types removal effort has removed the type from Index API in #47671 and from Get API in #46587
This commit allows to use 'typed' endpoints for the both Index and Get APIs

relates compatible types-removal meta issue #54160
@pgomulka pgomulka mentioned this issue Mar 31, 2021
Merged
pgomulka added a commit that referenced this issue Apr 19, 2021
@pgomulka
[Rest Compatible Api] include_type_name parameter (#70966)
3ef5e4c 
This commit allows to use the include_type_name parameter with the compatible rest api.
The support for include_type_name was previously removed in #48632

relates #51816
types removal meta issue #54160
@pgomulka pgomulka mentioned this issue Apr 19, 2021
Merged
pgomulka added a commit that referenced this issue May 10, 2021
@pgomulka
[Rest API Compatibility] Typed endpoints for Put and Get Mapping and …
668a72d 
…get field mappings (#71721)

Implements a V7 compatible typed endpoints for REST put and get mapping endpoints. Also for Get Field Mappings endpoints.
retrofits the REST layer change removed in #41676

relates main meta issue #51816
relates types removal issue #54160
@pgomulka pgomulka mentioned this issue May 10, 2021
Merged
pgomulka added a commit that referenced this issue May 12, 2021
@pgomulka
[Rest Api Compatibility] Typed endpoints for search and related endpo…
85ed910 
…ints (#72155)

Implements a V7 compatible typed endpoints for REST for search related apis
retrofits the REST layer change removed in #41640

relates main meta issue #51816
relates types removal issue #54160
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue May 14, 2021
@pgomulka
[Rest Api Compatibility] Typed endpoints for RestUpdateAction and Res…
0071ea2 
…tDeleteAction

the previously removed typed enpotins for Update and Delete are
retrofitted in this commit
the commit that removed them
elastic#47671

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka mentioned this issue May 14, 2021
Merged
pgomulka added a commit that referenced this issue May 18, 2021
@pgomulka
[Rest Api Compatibility] Typed endpoints for RestUpdateAction and Res…
d5bf72a 
…tDeleteAction (#73115)

the previously removed typed enpotins for Update and Delete are
retrofitted in this commit
the commit that removed them
#47671

relates main meta issue #51816
relates types removal issue #54160
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jun 16, 2021
@pgomulka
[Rest Api Compatibility] Validate Query typed api
3fdc8de 
Adds back typed endpoints for validate query api.
Previously removed in elastic#46927

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka mentioned this issue Jun 16, 2021
Merged
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jun 16, 2021
@pgomulka
[Rest Api Compatibility] Typed indexing stats
3b3b2bd 
the per type indexing stats is simplified and when _types is requested
it will return total stats for the index repeated under types/_doc/

the removal elastic#47203

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka mentioned this issue Jun 16, 2021
Merged
pgomulka added a commit that referenced this issue Jun 16, 2021
@pgomulka
[Rest Api Compatibility] Validate Query typed api (#74171)
67b7fd4 
Adds back typed endpoints for validate query api.
Previously removed in #46927

relates main meta issue #51816
relates types removal issue #54160
@pgomulka pgomulka mentioned this issue Jun 16, 2021
Merged
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jun 17, 2021
@pgomulka
[Rest Api Compatibility] Type metadata for docs used in simulate request
4c15725 
This commit allows to provide _type field on document ingested in
simulate pipeline requests.

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka mentioned this issue Jun 17, 2021
Merged
pgomulka added a commit that referenced this issue Jun 17, 2021
@pgomulka
[Rest Api Compatibility] Typed indexing stats (#74181)
fdc301f 
the per type indexing stats is simplified and when _types is requested
it will return total stats for the index repeated under types/_doc/

the removal #47203

relates main meta issue #51816
relates types removal issue #54160
pgomulka added a commit that referenced this issue Jun 21, 2021
@pgomulka
[Rest Api Compatibility] Type metadata for docs used in simulate requ…
073f080 
…est (#74222)

This commit allows to provide _type field on document ingested in
simulate pipeline requests.

relates main meta issue #51816
relates types removal issue #54160
pgomulka added a commit that referenced this issue Jun 23, 2021
@pgomulka
[Rest Api Compatibility] Typed and xpack graph explore api (#74185)
270eae5 
adds back the typed and xpack endpoints for graph explore api
prevoiusly removed in #46935

relates main meta issue #51816
relates types removal issue #54160
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jun 24, 2021
@pgomulka
[Rest Api Compatibility] Typed TermLookups
3812672 
Previously removed in elastic#46943
parsing type field in term lookup is now possible with rest
compatible api. The type field is ignored

relates main meta issue elastic#51816
relates type removal meta issue elastic#54160
@pgomulka pgomulka mentioned this issue Jun 24, 2021
Merged
pgomulka added a commit that referenced this issue Jun 28, 2021
@pgomulka
[Rest Api Compatibility] Typed TermLookups (#74544)
90f2271 
Previously removed in #46943
parsing type field in term lookup is now possible with rest
compatible api. The type field is ignored

relates main meta issue #51816
relates type removal meta issue #54160
This was referenced Jun 28, 2021
Merged
Merged
pgomulka added a commit that referenced this issue Jun 30, 2021
@pgomulka
[Rest Api Compatibility] Allow for type in geo shape query (#74553)
4fa1c8d 
Allowing to specify type in geo_shape query. previously removed by #47792
types removal compatible meta #54160
main meta issue #51816
pgomulka added a commit that referenced this issue Jun 30, 2021
@pgomulka
[Rest Api Compatibility] Types for Percolate Query Api (#74698)
603ebf7 
Previously removed in #46985. The yaml test is included in this PR, but
will be removed once #74689 is merged.

relates #54160
relates main meta issue #51816
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jul 8, 2021
@pgomulka
[Rest Api Compatibility] MoreLikeThisQuery with types
1e2f1b5 
previously removed in elastic#42198
also adding a type for MultiTermVectorsResponse in failures

relates elastic#54160
relates elastic#51816
@pgomulka pgomulka mentioned this issue Jul 8, 2021
Merged
pgomulka added a commit that referenced this issue Jul 12, 2021
@pgomulka
[Rest Api Compatibility] MoreLikeThisQuery with types (#75123)
ff8aede 
previously removed in #42198
also adding a type for MultiTermVectorsResponse in failures

relates #54160
relates #51816
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jul 19, 2021
@pgomulka
[Rest Api Compatibility] Do not return _doc for empty mappings in tem…
d3325de 
…plate

Previously the compatibility layer was alwayre returning an _doc for get
template.
This commit does not return _doc in mappings when mappings are empty.
Returning just {} empty object

also moving term lookups tests which are already fixed (relates elastic#74544)

relates elastic#70966
relates main meta issue elastic#51816
relates types removal meta elastic#54160
@pgomulka pgomulka mentioned this issue Jul 19, 2021
Merged
pgomulka added a commit that referenced this issue Jul 19, 2021
@pgomulka
[Rest Api Compatibility] Do not return _doc for empty mappings in tem…
5485d3e 
…plate (#75448)

Previously the compatibility layer was always returning an _doc in mappings for get
template.
This commit does not return _doc in empty mappings.
Returning just {} empty object (v7 and v8 behaviour)

also moving term lookups tests which are already fixed (relates #74544)

relates #70966
relates main meta issue #51816
relates types removal meta #54160
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Jul 19, 2021
@pgomulka
[Rest Api Compatibility] Typed query
fcce7af 
Type information is no longer available, thereofre type query in v7
compatibility is working as match_all query
previously removed in elastic#47207

relates main meta issue elastic#51816
relates types removal meta elastic#54160
@pgomulka pgomulka mentioned this issue Jul 19, 2021
Merged
ywangd pushed a commit to ywangd/elasticsearch that referenced this issue Jul 30, 2021
@pgomulka @ywangd
[Rest Api Compatibility] Do not return _doc for empty mappings in tem…
38f6db9 
…plate (elastic#75448)

Previously the compatibility layer was always returning an _doc in mappings for get
template.
This commit does not return _doc in empty mappings.
Returning just {} empty object (v7 and v8 behaviour)

also moving term lookups tests which are already fixed (relates elastic#74544)

relates elastic#70966
relates main meta issue elastic#51816
relates types removal meta elastic#54160
pgomulka added a commit that referenced this issue Aug 3, 2021
@pgomulka
[Rest Api Compatibility] Typed query (#75453)
f339282 
Type query support was removed in #47207. This query will throw an exception in v7 rest api compatibility indicating that the support was removed + deprecation warnings.
In v8 it will not be available and error about type query being not found will be returned.

relates main meta issue #51816
relates types removal meta #54160
@pgomulka
Copy link
Contributor Author

pgomulka commented Sep 8, 2021

all of the type related changes have been brought back under rest api compatibility (the rest layer only)
closing issue

@pgomulka pgomulka closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgomulka pgomulka

Labels
Meta v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakelandis @pgomulka @syedsouban