Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types from TermsLookup #46943

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Remove types from TermsLookup #46943

merged 4 commits into from
Sep 23, 2019

Conversation

romseygeek
Copy link
Contributor

Related to #41059

@romseygeek romseygeek added :Search/Search Search-related issues that do not fall into other categories >refactoring v8.0.0 labels Sep 20, 2019
@romseygeek romseygeek self-assigned this Sep 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jpountz jpountz mentioned this pull request Sep 20, 2019
Closed
66 tasks
@romseygeek
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

1 similar comment
@romseygeek
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

colings86
colings86 approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 4ebeca5 into elastic:master Sep 23, 2019
@romseygeek romseygeek deleted the types-removal/termslookup branch September 23, 2019 17:07
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
Closed
66 tasks
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jun 24, 2021
@pgomulka
[Rest Api Compatibility] Typed TermLookups
3812672 
Previously removed in elastic#46943
parsing type field in term lookup is now possible with rest
compatible api. The type field is ignored

relates main meta issue elastic#51816
relates type removal meta issue elastic#54160
@pgomulka pgomulka mentioned this pull request Jun 24, 2021
Merged
pgomulka added a commit that referenced this pull request Jun 28, 2021
@pgomulka
[Rest Api Compatibility] Typed TermLookups (#74544)
90f2271 
Previously removed in #46943
parsing type field in term lookup is now possible with rest
compatible api. The type field is ignored

relates main meta issue #51816
relates type removal meta issue #54160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colings86 colings86 colings86 approved these changes

@jtibshirani jtibshirani Awaiting requested review from jtibshirani

Assignees

@romseygeek romseygeek

Labels
>refactoring :Search/Search Search-related issues that do not fall into other categories v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romseygeek @elasticmachine @colings86 @jakelandis