Adjust reload keystore test to pass in FIPS #56889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing(AEADBadTagException). Other implementations from other Security Providers fail with a different exception and as such we cannot differentiate between a corrupted file and a wrong password in a foolproof way. In other tests such as in KeyStoreWrapperTests#testDecryptKeyStoreWithWrongPassword we handle this by matching both possible exception messages but it is not as easy to do in the REST yml tests. What's more, we don't have a way to skip YAML tests in FIPS mode, thus this change removes the matching of the exception string entirely so that the test can run successfully in FIPS mode.
jkakavas
added
>test-failure
|
Pinging @elastic/es-security (:Security/Security) |
ywangd
reviewed
May 19, 2020
| @@ -18,7 +18,6 @@ setup: | |||
| - is_true: nodes | |||
| - is_true: cluster_name | |||
| - match: { nodes.$node_id.reload_exception.type: "security_exception" } | |||
| - match: { nodes.$node_id.reload_exception.reason: "Provided keystore password was incorrect" } | |||
There was a problem hiding this comment.
FWIW, it is possible to test for both error texts with regex
- match: { nodes.$node_id.reload_exception.reason:
/^(Provided\skeystore\spassword\swas\sincorrect|
Keystore\shas\sbeen\scorrupted\sor\stampered\swith)$/ }
This can actually be changed to 7.6.99, the password protected keystore is in 7.x and 7.7. Spotted in #55069 but refrained from changing since I would change it soon ( but then failed to , which I'll do in a followup PR for all branches today ) |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 19, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing(AEADBadTagException). Other implementations from other Security Providers fail with a different exception and as such we cannot differentiate between a corrupted file and a wrong password in a foolproof way. As in other tests such as in KeyStoreWrapperTests#testDecryptKeyStoreWithWrongPassword we handle this by matching both possible exception messages.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 19, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing(AEADBadTagException). Other implementations from other Security Providers fail with a different exception and as such we cannot differentiate between a corrupted file and a wrong password in a foolproof way. As in other tests such as in KeyStoreWrapperTests#testDecryptKeyStoreWithWrongPassword we handle this by matching both possible exception messages.
jkakavas
added a commit
that referenced
this pull request
May 19, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing(AEADBadTagException). Other implementations from other Security Providers fail with a different exception and as such we cannot differentiate between a corrupted file and a wrong password in a foolproof way. As in other tests such as in KeyStoreWrapperTests#testDecryptKeyStoreWithWrongPassword we handle this by matching both possible exception messages.
jkakavas
added a commit
that referenced
this pull request
May 19, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing(AEADBadTagException). Other implementations from other Security Providers fail with a different exception and as such we cannot differentiate between a corrupted file and a wrong password in a foolproof way. As in other tests such as in KeyStoreWrapperTests#testDecryptKeyStoreWithWrongPassword we handle this by matching both possible exception messages.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 21, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers fail with a different exception and as such we cannot differentiate between a corrupted file and a wrong passwordin a foolproof way. we handle this in this test by matching both possible exception messages. Relates: elastic#56889
jkakavas
added a commit
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: #56889
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: elastic#56889
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: elastic#56889
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: elastic#56889
jkakavas
added a commit
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: #56889
jkakavas
added a commit
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: #56889
jkakavas
added a commit
that referenced
this pull request
May 26, 2020
In KeystoreWrapper class we determine if the error to decrypt a given keystore is caused by a wrong password based on the exception that the SunJCE implementation of AES is throwing (AEADBadTagException). Other implementations from other Security Providers might cause decryption to fail in a different way and cause us to throw a generic error message. We handle this in this test by matching both possible exception messages. Relates: #56889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In KeystoreWrapper class we determine if the error to decrypt a
given keystore is caused by a wrong password based on the exception
that the SunJCE implementation of AES is
throwing(AEADBadTagException). Other implementations from other
Security Providers fail with a different exception and as such we
cannot differentiate between a corrupted file and a wrong password
in a foolproof way.
As in other tests such as in
KeyStoreWrapperTests#testDecryptKeyStoreWithWrongPassword
we handle this by matching both possible exception messages.