Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust version mute for reload secure settings #56938

Merged
merged 1 commit into from
May 19, 2020

Conversation

jkakavas
Copy link
Member

We can safely run the reload_secure_settings tests
after 7.7.0 , the relevant changes have long been
backported there

We can safely run this test after 7.7.0
@jkakavas jkakavas added >test Issues or PRs that are addressing/adding tests :Core/Infra/REST API REST infrastructure and utilities v8.0.0 v7.8.1 labels May 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 19, 2020
@jkakavas jkakavas requested a review from mark-vieira May 19, 2020 11:32
version: " - 7.9.99"
reason: "support for reloading password protected keystores was introduced in 8.0.0"
version: " - 7.6.99"
reason: "support for reloading password protected keystores was introduced in 7.7.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I see this PR is missing labels for 7.7 and 7.x branches. I assume i should be backported there as well?

@jkakavas
Copy link
Member Author

however I see this PR is missing labels for 7.7 and 7.x branches. I assume i should be backported there as well?

We don't have a 7.x label for such cases, I just use the latest available from 7.x to denote that I'll be backporting it. 7.7 is taken care of and I will backport tthis to 7.x and 7.8`

@jkakavas jkakavas merged commit 127646c into elastic:master May 19, 2020
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request May 19, 2020
We can safely run the reload_secure_settings tests
after 7.7.0 , the relevant changes have long been
backported there
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request May 19, 2020
We can safely run the reload_secure_settings tests
after 7.7.0 , the relevant changes have long been
backported there
jkakavas added a commit that referenced this pull request May 19, 2020
We can safely run the reload_secure_settings tests
after 7.7.0 , the relevant changes have long been
backported there
jkakavas added a commit that referenced this pull request May 19, 2020
We can safely run the reload_secure_settings tests
after 7.7.0 , the relevant changes have long been
backported there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.8.1 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants