Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Typed and xpack graph explore api #74185

Merged
merged 4 commits into from
Jun 23, 2021
Merged

[Rest Api Compatibility] Typed and xpack graph explore api #74185

merged 4 commits into from
Jun 23, 2021

Conversation

pgomulka
Copy link
Contributor

adds back the typed and xpack endpoints for graph explore api
prevoiusly removed in #46935

relates main meta issue #51816
relates types removal issue #54160

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jun 16, 2021
@pgomulka pgomulka self-assigned this Jun 16, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka
[Rest Api Compatibility] Typed and xpack graph explore api
e95dd9c 
adds back the typed and xpack endpoints for  graph explore api
prevoiusly removed in elastic#46935

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka mentioned this pull request Jun 16, 2021
Closed
66 tasks
@pgomulka
Copy link
Contributor Author

@elasticmachine update branch

@pgomulka pgomulka requested a review from romseygeek June 17, 2021 07:59
romseygeek
romseygeek approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I left one comment about testing

...ugin/graph/src/test/java/org/elasticsearch/xpack/graph/rest/action/RestGraphActionTests.java
});
}

public void testTypeInPath() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for the _xpath variant as well?

Copy link
Contributor Author

@pgomulka pgomulka Jun 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, in fact not all endpoints are correctly deprecated. /{index}/{type}/_xpack/graph/_explore api was indicating to use /{index}/{type}/_graph/explore
I will update this on 7.x and then update this PR too

@pgomulka pgomulka merged commit 270eae5 into elastic:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees

@pgomulka pgomulka

Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @romseygeek @jakelandis