Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rest Api Compatibility] Add conditions to InjectHeaders transformation #75001

Merged

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 6, 2021

adding a conditions that has to be satisfied in order to apply headers in InjectHeaders.
this will allow to skip the transformation for cat operations
relates #51816

@pgomulka pgomulka added the >test Issues or PRs that are addressing/adding tests label Jul 6, 2021
@pgomulka pgomulka requested a review from jakelandis July 6, 2021 16:49
@pgomulka pgomulka self-assigned this Jul 6, 2021

/**
* @param headers The headers to inject
* @param applyConditions a set of conditions that has to be satisfied in order to apply headers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "If the Set is empty then headers are always applied"

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only a nitpick on the javadoc.

@pgomulka pgomulka merged commit 9bb4734 into elastic:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants