-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rest Api Compatibility] Add conditions to InjectHeaders transformation #75001
Merged
pgomulka
merged 22 commits into
elastic:master
from
pgomulka:compat/add_conditions_to_inject_headers
Jul 7, 2021
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d559a6c
xpack enable all
pgomulka 0e3d482
Merge remote-tracking branch 'upstream/master' into compat/xpack_enab…
pgomulka bdfec6a
ml json cannonical
pgomulka 48decde
investigating copying regex
pgomulka 46989c0
Merge remote-tracking branch 'upstream/master' into compat/xpack_enab…
pgomulka 32502d6
Merge branch 'master' into compat/xpack_enable_all
elasticmachine 98d8c7d
Merge remote-tracking branch 'refs/remotes/pgomulka/compat/xpack_enab…
pgomulka d4276cb
ml cleanup
pgomulka 4a32d3d
revert groovy test
pgomulka c1163a5
do not modify cat headers
pgomulka 9314dd7
filter cat.
pgomulka b41d308
remove comments
pgomulka fe46612
move roles to ignore
pgomulka f3e5311
Merge remote-tracking branch 'upstream/master' into compat/xpack_enab…
pgomulka 5fb01c3
rename
pgomulka fddccc5
Merge remote-tracking branch 'upstream/master' into compat/xpack_enab…
pgomulka c3b9f30
enable ml related
pgomulka 08db9a1
disable ml tests which won't be worked on
pgomulka 7ad7093
apply condition to inject headers
pgomulka 4c539f5
human debug
pgomulka d9a264d
revert enable_all changes
pgomulka 2b2a342
javadoc
pgomulka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...ternal/src/test/resources/rest/transform/header/with_operation_to_skip_adding_headers.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
setup: | ||
- skip: | ||
features: headers | ||
--- | ||
"Test without a setup": | ||
- do: | ||
headers: | ||
foo: "bar" | ||
something_to_skip: | ||
id: "something" | ||
- match: { acknowledged: true } | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add "If the Set is empty then headers are always applied"