[Rest Api Compatibility] Typed query #75453
Conversation
Type information is no longer available, thereofre type query in v7 compatibility is working as match_all query previously removed in elastic#47207 relates main meta issue elastic#51816 relates types removal meta elastic#54160
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
|
||
| @Override | ||
| protected Query doToQuery(SearchExecutionContext context) throws IOException { | ||
| return new MatchAllDocsQuery(); |
There was a problem hiding this comment.
We do actually still have type information available: context.mappingLookup().getMapping().getRoot().name(). So you could check against the top-level type and then return a MatchAll/MatchNone depending on whether or not you get a match.
There was a problem hiding this comment.
so you suggest to check if the value used on a type query is _doc (this is the only type we can have, right?) then return matchAll otherwise matchNone?
There was a problem hiding this comment.
what values can I expect from context.mappingLookup().getMapping().getRoot().name() ?
There was a problem hiding this comment.
You can still specify non-_doc type names in 7x indexes. context .... name() will return the type name of the current index.
| @@ -0,0 +1,89 @@ | |||
| /* | |||
There was a problem hiding this comment.
Rather than adding this back into the core server package, could we put it into a separate module instead? I think that would avoid changes to Node as well.
There was a problem hiding this comment.
good idea, will do this
There was a problem hiding this comment.
For the sake of simplicity I kept this query in the server module (same package as previously)
I was worried that if we keep all v7 queries in single module it will have far too many dependencies.
|
@romseygeek I have refactored the way we register queries in #75722 so that registering new compatible only queries looks almost the same as the 'current version' queries. |
Type query support was removed in #47207. This query will throw an exception in v7 rest api compatibility indicating that the support was removed + deprecation warnings.
In v8 it will not be available and error about
typequery being not found will be returned.relates main meta issue #51816
relates types removal meta #54160