Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.3] Bound random negative size test in SearchSourceBuilderTests#testNegativeSizeErrors (#88457) #88468

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[8.3] Bound random negative size test in SearchSourceBuilderTests#testNegativeSizeErrors (#88457) #88468

merged 1 commit into from
Jul 12, 2022

Conversation

matschaffer
Copy link
Contributor

Backports the following commits to 8.3:

@matschaffer
Bound random negative size test in SearchSourceBuilderTests#testNegat…
e492b4b 
…iveSizeErrors (elastic#88457)

-1 is handled differently by the xcontent code path so this test will fail when `randomIntBetween` lands on -1.

To fix, we add another integer for the xcontent test which starts at -2.
@matschaffer matschaffer added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI backport Team:Search Meta label for search team labels Jul 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine mentioned this pull request Jul 12, 2022
Merged
@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.3.3 labels Jul 12, 2022
@javanna javanna merged commit 8fcc4ca into elastic:8.3 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport external-contributor Pull request authored by a developer outside the Elasticsearch team :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI v8.3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matschaffer @elasticmachine @javanna @elasticsearchmachine