Re-compile accessibility icon; remove default titling from EuiIcon (#…

…2632) * Re-compile accessibility icon; remove default titling from EuiIcon * changelog * Update EuiIcon logic for when to set aria-hidden * fix changelog entry
elastic · Dec 12, 2019 · ed295a7 · ed295a7
1 parent 20b87df
commit ed295a7
Show file tree

Hide file tree

Showing 56 changed files with 766 additions and 1,742 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 **Bug fixes**
 
 - Fixed `EuiCodeEditor` custom mode file error by initializing with existing mode ([#2616](https://github.com/elastic/eui/pull/2616))
+- Removed `EuiIcon` default titles ([#2632](https://github.com/elastic/eui/pull/2632))
 
 ## [`17.1.1`](https://github.com/elastic/eui/tree/v17.1.1)
 

diff --git a/src/components/accordion/__snapshots__/accordion.test.tsx.snap b/src/components/accordion/__snapshots__/accordion.test.tsx.snap
@@ -29,16 +29,13 @@ exports[`EuiAccordion behavior closes when clicked twice 1`] = `
           >
             <EuiIconEmpty
               aria-hidden={true}
-              aria-label=""
               className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
               focusable="false"
               role="img"
               style={null}
-              title=""
             >
               <svg
                 aria-hidden={true}
-                aria-label=""
                 className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
                 focusable="false"
                 height={16}
@@ -110,16 +107,13 @@ exports[`EuiAccordion behavior opens when clicked once 1`] = `
           >
             <EuiIconEmpty
               aria-hidden={true}
-              aria-label=""
               className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon euiAccordion__icon-isOpen"
               focusable="false"
               role="img"
               style={null}
-              title=""
             >
               <svg
                 aria-hidden={true}
-                aria-label=""
                 className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon euiAccordion__icon-isOpen"
                 focusable="false"
                 height={16}
@@ -182,7 +176,6 @@ exports[`EuiAccordion is rendered 1`] = `
       >
         <svg
           aria-hidden="true"
-          aria-label=""
           class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
           focusable="false"
           height="16"
@@ -226,7 +219,6 @@ exports[`EuiAccordion props buttonContent is rendered 1`] = `
       >
         <svg
           aria-hidden="true"
-          aria-label=""
           class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
           focusable="false"
           height="16"
@@ -274,7 +266,6 @@ exports[`EuiAccordion props buttonContentClassName is rendered 1`] = `
       >
         <svg
           aria-hidden="true"
-          aria-label=""
           class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
           focusable="false"
           height="16"
@@ -320,7 +311,6 @@ exports[`EuiAccordion props extraAction is rendered 1`] = `
       >
         <svg
           aria-hidden="true"
-          aria-label=""
           class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
           focusable="false"
           height="16"
@@ -371,7 +361,6 @@ exports[`EuiAccordion props initialIsOpen is rendered 1`] = `
       >
         <svg
           aria-hidden="true"
-          aria-label=""
           class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon euiAccordion__icon-isOpen"
           focusable="false"
           height="16"

diff --git a/src/components/badge/__snapshots__/badge.test.tsx.snap b/src/components/badge/__snapshots__/badge.test.tsx.snap
@@ -216,7 +216,6 @@ exports[`EuiBadge props iconSide left is rendered 1`] = `
     </span>
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--small euiIcon-isLoading euiBadge__icon"
       focusable="false"
       height="16"
@@ -243,7 +242,6 @@ exports[`EuiBadge props iconSide right is rendered 1`] = `
     </span>
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--small euiIcon-isLoading euiBadge__icon"
       focusable="false"
       height="16"
@@ -270,7 +268,6 @@ exports[`EuiBadge props iconType is rendered 1`] = `
     </span>
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--small euiIcon-isLoading euiBadge__icon"
       focusable="false"
       height="16"

diff --git a/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap b/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap
@@ -19,7 +19,6 @@ exports[`CollapsedItemActions render 1`] = `
       >
         <svg
           aria-hidden="true"
-          aria-label=""
           class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
           focusable="false"
           height="16"

diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
@@ -387,16 +387,13 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
                                   >
                                     <EuiIconEmpty
                                       aria-hidden={true}
-                                      aria-label=""
                                       className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
                                       focusable="false"
                                       role="img"
                                       style={null}
-                                      title=""
                                     >
                                       <svg
                                         aria-hidden={true}
-                                        aria-label=""
                                         className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
                                         focusable="false"
                                         height={16}
@@ -472,16 +469,13 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
                               >
                                 <EuiIconEmpty
                                   aria-hidden={true}
-                                  aria-label=""
                                   className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
                                   focusable="false"
                                   role="img"
                                   style={null}
-                                  title=""
                                 >
                                   <svg
                                     aria-hidden={true}
-                                    aria-label=""
                                     className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
                                     focusable="false"
                                     height={16}
@@ -616,16 +610,13 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
                               >
                                 <EuiIconEmpty
                                   aria-hidden={true}
-                                  aria-label=""
                                   className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
                                   focusable="false"
                                   role="img"
                                   style={null}
-                                  title=""
                                 >
                                   <svg
                                     aria-hidden={true}
-                                    aria-label=""
                                     className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
                                     focusable="false"
                                     height={16}

diff --git a/src/components/button/__snapshots__/button.test.tsx.snap b/src/components/button/__snapshots__/button.test.tsx.snap
@@ -166,7 +166,6 @@ exports[`EuiButton props iconSide left is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButton__icon"
       focusable="false"
       height="16"
@@ -194,7 +193,6 @@ exports[`EuiButton props iconSide right is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButton__icon"
       focusable="false"
       height="16"
@@ -222,7 +220,6 @@ exports[`EuiButton props iconType is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButton__icon"
       focusable="false"
       height="16"

diff --git a/src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap b/src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap
@@ -151,7 +151,6 @@ exports[`EuiButtonEmpty props iconSide left is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
       focusable="false"
       height="16"
@@ -179,7 +178,6 @@ exports[`EuiButtonEmpty props iconSide right is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
       focusable="false"
       height="16"
@@ -207,7 +205,6 @@ exports[`EuiButtonEmpty props iconType is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
       focusable="false"
       height="16"

diff --git a/src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap b/src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap
@@ -91,7 +91,6 @@ exports[`EuiButtonIcon props iconType is rendered 1`] = `
 >
   <svg
     aria-hidden="true"
-    aria-label=""
     class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
     focusable="false"
     height="16"

diff --git a/src/components/call_out/__snapshots__/call_out.test.tsx.snap b/src/components/call_out/__snapshots__/call_out.test.tsx.snap
@@ -184,7 +184,6 @@ exports[`EuiCallOut props iconType is rendered 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiCallOutHeader__icon"
       focusable="false"
       height="16"

diff --git a/src/components/card/__snapshots__/card.test.tsx.snap b/src/components/card/__snapshots__/card.test.tsx.snap
@@ -195,7 +195,6 @@ exports[`EuiCard props icon 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon--app euiIcon-isLoading myIconClass euiCard__icon"
       focusable="false"
       height="16"

diff --git a/src/components/card/__snapshots__/card_select.test.tsx.snap b/src/components/card/__snapshots__/card_select.test.tsx.snap
@@ -91,7 +91,6 @@ exports[`EuiCardSelect props isSelected 1`] = `
   >
     <svg
       aria-hidden="true"
-      aria-label=""
       class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
       focusable="false"
       height="16"

diff --git a/src/components/code/__snapshots__/code_block.test.js.snap b/src/components/code/__snapshots__/code_block.test.js.snap
@@ -81,7 +81,6 @@ console.log(some);
         >
           <svg
             aria-hidden="true"
-            aria-label=""
             class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
             focusable="false"
             height="16"
@@ -140,7 +139,6 @@ console.log(some);
     >
       <svg
         aria-hidden="true"
-        aria-label=""
         class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
         focusable="false"
         height="16"

diff --git a/src/components/color_picker/__snapshots__/color_picker.test.tsx.snap b/src/components/color_picker/__snapshots__/color_picker.test.tsx.snap
@@ -39,7 +39,6 @@ exports[`renders EuiColorPicker 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -61,7 +60,6 @@ exports[`renders EuiColorPicker 1`] = `
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -117,7 +115,6 @@ exports[`renders EuiColorPicker with a color swatch when color is defined 1`] =
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -139,7 +136,6 @@ exports[`renders EuiColorPicker with a color swatch when color is defined 1`] =
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -194,7 +190,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is "" 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -216,7 +211,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is "" 1`] = `
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -271,7 +265,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is null 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -293,7 +286,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is null 1`] = `
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -349,7 +341,6 @@ exports[`renders compressed EuiColorPicker 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -371,7 +362,6 @@ exports[`renders compressed EuiColorPicker 1`] = `
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -428,7 +418,6 @@ exports[`renders disabled EuiColorPicker 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -450,7 +439,6 @@ exports[`renders disabled EuiColorPicker 1`] = `
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -506,7 +494,6 @@ exports[`renders fullWidth EuiColorPicker 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"
@@ -528,7 +515,6 @@ exports[`renders fullWidth EuiColorPicker 1`] = `
           >
             <svg
               aria-hidden="true"
-              aria-label=""
               class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
               focusable="false"
               height="16"
@@ -768,7 +754,6 @@ exports[`renders readOnly EuiColorPicker 1`] = `
                 >
                   <svg
                     aria-hidden="true"
-                    aria-label=""
                     class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                     focusable="false"
                     height="16"

diff --git a/src/components/combo_box/__snapshots__/combo_box.test.js.snap b/src/components/combo_box/__snapshots__/combo_box.test.js.snap
@@ -46,7 +46,6 @@ exports[`EuiComboBox is rendered 1`] = `
         >
           <svg
             aria-hidden="true"
-            aria-label=""
             class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
             focusable="false"
             height="16"
@@ -267,7 +266,6 @@ exports[`props options list is rendered 1`] = `
         >
           <svg
             aria-hidden="true"
-            aria-label=""
             class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
             focusable="false"
             height="16"