Re-compile accessibility icon; remove default titling from EuiIcon #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
suggested changes
Dec 11, 2019
cchaos
approved these changes
Dec 12, 2019
|
jenkins test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While upgrading Kibana's version of EUI to include the recent icon accessibility changes, I found that unit tests using enzyme's
.text()method now include the contents of the svg'stitleelement. Looking further, I noticed that a large number of icon usages did not benefit from the default title (e.g. a title of "bolt" is non-descriptive). After discussing with @cchaos and @snide we decided to revert the decision to apply the icon name as the default title and instead rely solely on title and aria-label props be provided by the consumer.I also recompiled the existing icons as I noticed Accessibility was in the old format.
/cc @myasonik @snide
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples