Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTourStep] euiTourStep.closeTour default token value should be more specific #4787

Closed
afharo opened this issue May 10, 2021 · 1 comment · Fixed by #4790
Closed

[EuiTourStep] euiTourStep.closeTour default token value should be more specific #4787

afharo opened this issue May 10, 2021 · 1 comment · Fixed by #4790

Comments

@afharo
Copy link
Member

afharo commented May 10, 2021

When adding tests in Kibana to ensure we keep our i18n labels in sync with this project (elastic/kibana#99613), I noticed that the label euiTourStep.closeTour is translated differently in Kibana: instead of "Close" as defined in this repo, it claims "Close tour".

  • "Close" seems consistent across the UI for any pop-up/overlay
  • However, all the other "tour" labels include the word "tour": "End tour" & "Skip tour", so "Close tour" would be consistent with their siblings in this context.

What do you think it's the best translation here?

@cchaos
Copy link
Contributor

cchaos commented May 10, 2021

I prefer being as specific as possible. If other translations are using the word tour, I'd stick with that pattern. It was most likely just an oversight from the initial creation.

@miukimiu miukimiu changed the title [discuss] "Close" or "Close tour" [EuiTourStep] euiTourStep.closeTour default token value should be more specific May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants