Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed euiTourStep.closeTour #4789

Closed
wants to merge 1 commit into from

Conversation

hetanthakkar
Copy link
Contributor

@hetanthakkar hetanthakkar commented May 10, 2021

Summary

Fixes #4787

Checklist

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@miukimiu
Copy link
Contributor

Thanks @hetanthakkar1 for creating this PR. I'm closing it in favor of #4790.

The i8ntokens.json is a file generated during a build and release. So we shouldn't change it manually. You can take a look at how to update i18n tokens here.

@miukimiu miukimiu closed this May 10, 2021
@hetanthakkar
Copy link
Contributor Author

Opps! That waa a blunder. I shouldn't have done it thay way. You're right. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiTourStep] euiTourStep.closeTour default token value should be more specific
3 participants