Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTourStep] Fixed euiTourStep.closeTour default token value to be more specific #4790

Merged
merged 2 commits into from
May 11, 2021

Conversation

miukimiu
Copy link
Contributor

Summary

Closes #4787.

This PR updates the euiTourStep.closeTour default token value in EuiTourStep to be more specific and consistent with other buttons: "End tour" and "Skip tour".

Frame 4@2x

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu mentioned this pull request May 10, 2021
10 tasks
@miukimiu
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4790/

@miukimiu miukimiu merged commit e6e47ad into elastic:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiTourStep] euiTourStep.closeTour default token value should be more specific
4 participants