Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiFormControlLayoutClearButton converted to TS #1922

Merged
merged 3 commits into from
May 21, 2019
Merged

EuiFormControlLayoutClearButton converted to TS #1922

merged 3 commits into from
May 21, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented May 7, 2019

Summary

Converted EuiFormControlLayoutClearButton to TS + Tests

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

chandlerprall
chandlerprall suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test! One small nit, and needs a changelog

src/components/form/form_control_layout/form_control_layout_clear_button.tsx Outdated Show resolved Hide resolved
@theodesp theodesp force-pushed the task/EuiFormControlLayoutClearButton-to-TS branch from 295ce3d to 98423db Compare May 13, 2019 10:26
@theodesp
Copy link
Contributor Author

@chandlerprall PR updated

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

@thompsongl Conflicts resolved

@thompsongl thompsongl merged commit a0c7aa0 into elastic:master May 21, 2019
@theodesp theodesp deleted the task/EuiFormControlLayoutClearButton-to-TS branch May 29, 2019 09:17
@thompsongl thompsongl mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall requested changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodesp @elasticmachine @thompsongl @chandlerprall