Upgrade EUI to 11.3.2 #38262

thompsongl · 2019-06-06T13:49:34Z

Summary

11.0.1 ⏩ 11.3.1

Notable: EuiColorPicker has been rebuilt and restyled, but with a compatible API.

`11.3.1`

Bug fixes

Fixed EuiBadge conflicts with providing both iconOnClick and onClick (#1994)
Fixed optional TS definitions for EuiColorPicker onBlur and onFocus callbacks (#1993)
Fixed EuiIcon again so that webpack can build dynamic require contexts (#1998)
Fixed double borders on prepend/append items in EuiFormControlLayout (#1996)
Fixed EuiSuperSelect TS definitions (#1995)

`11.3.0`

Converted EuiTableRowHeaderCheckbox to TS (#1973)
Added missing TypeScript definition for EuiFieldText's compressed prop (#1977)
Converted EuiTableRowCellCheckbox to TS (#1964)
Updated caniuse-lite version resolution (#1970)
Added a webpack directive for naming icon chunks (#1944)
Added ability to update EuiInMemoryTable sorting prop and remove columns after sorting is applied (#1972)
Added onToggle callback to EuiAccordion (#1974)
Removed options defaultProps value from EuiSuperSelect (#1975)
Removed TSlint and will perform all linting through ESLint (#1950)
Added new component EuiDelayRender (#1876)
Replaced EuiColorPicker with custom, customizable component (#1914)
Added jsx-a11y eslint plugin and rules to match Kibana (#1952)
Changed EuiCopy beforeMessage prop to accept node instead of just string (#1952)

Bug fixes

Fixed environment setup for running test-unit script on Windows (#1971)
Fixed focus on single selection of EuiComboBox (#1965)
Fixed type mismatch between PropType and TypeScript def for EuiGlobalToastList toast title (#1978)
Fixed missing Typescript definition for EuiButton's color="text" option (#1980)
Fixed Prettier formatting lint error in EuiTable TS def file (#1986)
Fixed not clickable button with svg in Safari (#1985)
Fixed EuiToggle pointer events for those using icons only (#1991)

`11.2.1`

Bug fixes

Fixed type mismatch between PropType and TypeScript def for EuiToast title (#1962)

`11.2.0`

Converted EuiFormControlLayoutCustomIcon to TS (#1956)
Converted EuiStepNumber to TS (#1893)
Converted EuiFormControlLayoutClearButton to TS (#1922)
Added data-test-subj property to EuiDraggable and EuiDroppable (#1943)
Added type definitions to EuiSuperSelect (#1907)
Updated EuiIcon to use Slack's updated branding (#1954)
Updated compile-icons script to format icon components with Prettier (#1955)

Bug fixes

Addressed a chrome issue where negative letter-spacing can reverse RTL text in SVGs (#1960)

`11.1.0`

Converted pretty_interval to TS (#1920)
Converted relative_options to TS (#1921)
Added width to EuiFlexItem when gutter in EuiFlexGrid is set to none. (#1941)
Format all JavaScript files with Prettier through ESLint (#1906)
Replaced appSecurityAnalytics in EuiIcon with an updated SVG (#1948)

Bug fixes

Removed unused prop enum of l in EuiButton (#1936)
Fixed EuiSelect browser event inconsistencies by normalizing mouseup propagation (#1926)
Removed children as a required prop for EuiOverlayMask (#1937)

chandlerprall

one devex change requested, otherwise looks good!

...dit_role/components/privileges/kibana/space_aware_privilege_section/privilege_space_form.tsx

elasticmachine · 2019-06-06T16:53:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-06T18:01:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-06T18:28:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Updates Canvas storyshots

cqliu1

No issues with the updates to the Canvas snapshots. Only EUI component related code was updated in the snapshots. I just had one question about the types in the FontPicker component.

x-pack/plugins/canvas/public/components/font_picker/font_picker.tsx

elasticmachine · 2019-06-06T20:52:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-06T22:36:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-11T18:00:53Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

PhilippBaranovskiy

In the existing issues I know that code looks good.

spalger · 2019-06-12T14:17:06Z

Seems we were duplicating work in #38434, let's use this PR instead

thompsongl · 2019-06-12T18:16:17Z

Seems we were duplicating work in #38434, let's use this PR instead

We found a bug introduced in the jump, too, so this will go to 11.3.2 once EUI is updated

elasticmachine · 2019-06-12T19:13:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-12T20:46:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-14T17:57:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

legrego

Since the new color picker allows for invalid hex, it's possible for users to get themselves into a state where their space won't save:

The components on this page really aren't setup to quickly fix this, and I don't want to block your PR on this edge case. I'll open an issue for us to correct it once this merges.

snide

Ran local. Issues look fixed.

* Upgrade EUI to 11.3.2 (#38262) * eui 11.3.1 * EuiSuperSelect TS updates * EuiColorPicker updates * EuiBadge updates * a11y updates * i18n service updates * remove unused translations * move valueOfSelected logic to private method * update EuiColorPicker class name * Updated canvas storyshots * i18n fixes; maps color selection position * i18n snapshot updates * update canvas storyshots * snapshot updates * 11.3.2 * maps colorpicker * space avatar colorpicker * update i18n json

thompsongl added 6 commits June 6, 2019 08:38

eui 11.3.1

90ad3f6

EuiSuperSelect TS updates

6f28938

EuiColorPicker updates

07f2cf4

EuiBadge updates

72ebfeb

a11y updates

93e166d

i18n service updates

1a77c6f

thompsongl added chore v8.0.0 v7.3.0 labels Jun 6, 2019

thompsongl requested a review from chandlerprall June 6, 2019 13:49

thompsongl requested review from a team as code owners June 6, 2019 13:49

remove unused translations

9c05c3e

chandlerprall approved these changes Jun 6, 2019

View reviewed changes

...dit_role/components/privileges/kibana/space_aware_privilege_section/privilege_space_form.tsx Outdated Show resolved Hide resolved

thompsongl added 2 commits June 6, 2019 10:22

move valueOfSelected logic to private method

910996d

update EuiColorPicker class name

51cff3a

thompsongl requested a review from a team June 6, 2019 15:37

Merge branch 'master' into eui/11.3

8bd1547

cqliu1 and others added 2 commits June 6, 2019 13:17

Updated canvas storyshots

6878c00

Merge pull request #1 from cqliu1/eui/11.3-PATCH

e1229eb

Updates Canvas storyshots

cqliu1 requested changes Jun 6, 2019

View reviewed changes

x-pack/plugins/canvas/public/components/font_picker/font_picker.tsx Show resolved Hide resolved

cqliu1 approved these changes Jun 6, 2019

View reviewed changes

Merge branch 'master' into eui/11.3

2329124

thompsongl added 2 commits June 11, 2019 17:02

update canvas storyshots

0359858

i18n snapshot updates

859bcd5

sulemanof mentioned this pull request Jun 12, 2019

[Vis: Default editor] EUIficate date_ranges param editor #38647

Merged

7 tasks

PhilippBaranovskiy self-requested a review June 12, 2019 14:03

PhilippBaranovskiy approved these changes Jun 12, 2019

View reviewed changes

spalger mentioned this pull request Jun 12, 2019

Update dependency @elastic/eui to v11.3.1 - autoclosed #38434

Closed

1 task

thompsongl added 2 commits June 12, 2019 10:40

Merge branch 'master' into eui/11.3

32a0d1b

snapshot updates

9beaafa

Merge branch 'master' into eui/11.3

4dbf040

ryankeairns mentioned this pull request Jun 13, 2019

Font controls in sidebar do not work #38939

Closed

thompsongl added 5 commits June 14, 2019 09:28

Merge branch 'master' into eui/11.3

f2d8f6a

11.3.2

b1d381d

maps colorpicker

c045941

space avatar colorpicker

a2be37e

Merge branch 'master' into eui/11.3

1674a72

thompsongl changed the title ~~Upgrade EUI to 11.3.1~~ Upgrade EUI to 11.3.2 Jun 14, 2019

thompsongl added the release_note:skip Skip the PR/issue when compiling release notes label Jun 14, 2019

legrego approved these changes Jun 14, 2019

View reviewed changes

snide approved these changes Jun 14, 2019

View reviewed changes

thompsongl merged commit c22b706 into elastic:master Jun 14, 2019

thompsongl mentioned this pull request Jun 14, 2019

[7.x] Upgrade EUI to 11.3.2 (#38262) #39031

Merged

angorayc mentioned this pull request Jun 16, 2019

[SIEM] Update button size for EuiButton #39051

Merged

legrego mentioned this pull request Jun 17, 2019

Space management color picker #39067

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to 11.3.2 #38262

Upgrade EUI to 11.3.2 #38262

thompsongl commented Jun 6, 2019

chandlerprall left a comment

elasticmachine commented Jun 6, 2019

elasticmachine commented Jun 6, 2019

elasticmachine commented Jun 6, 2019

cqliu1 left a comment

elasticmachine commented Jun 6, 2019

elasticmachine commented Jun 6, 2019

elasticmachine commented Jun 11, 2019

PhilippBaranovskiy left a comment

spalger commented Jun 12, 2019 •

edited

Loading

thompsongl commented Jun 12, 2019

elasticmachine commented Jun 12, 2019

elasticmachine commented Jun 12, 2019

elasticmachine commented Jun 14, 2019

legrego left a comment

snide left a comment

Upgrade EUI to 11.3.2 #38262

Upgrade EUI to 11.3.2 #38262

Conversation

thompsongl commented Jun 6, 2019

Summary

11.3.1

11.3.0

11.2.1

11.2.0

11.1.0

chandlerprall left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 6, 2019

💔 Build Failed

elasticmachine commented Jun 6, 2019

💔 Build Failed

elasticmachine commented Jun 6, 2019

💔 Build Failed

cqliu1 left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 6, 2019

💔 Build Failed

elasticmachine commented Jun 6, 2019

💔 Build Failed

elasticmachine commented Jun 11, 2019

💔 Build Failed

PhilippBaranovskiy left a comment

Choose a reason for hiding this comment

spalger commented Jun 12, 2019 • edited Loading

thompsongl commented Jun 12, 2019

elasticmachine commented Jun 12, 2019

💔 Build Failed

elasticmachine commented Jun 12, 2019

💔 Build Failed

elasticmachine commented Jun 14, 2019

💚 Build Succeeded

legrego left a comment

Choose a reason for hiding this comment

snide left a comment

Choose a reason for hiding this comment

`11.3.1`

`11.3.0`

`11.2.1`

`11.2.0`

`11.1.0`

spalger commented Jun 12, 2019 •

edited

Loading