Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isDisabled prop to EuiSuperDatePicker #2139

Merged
merged 6 commits into from
Jul 26, 2019
Merged

Add isDisabled prop to EuiSuperDatePicker #2139

merged 6 commits into from
Jul 26, 2019

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 18, 2019 •
edited
Loading

Summary

Fixes #2081. Adds a isDisabled prop to EuiSuperDatePicker which disables interactions with the various controls.

  • Needs a design pass to style the disabled buttons, new classes euiSuperDatePicker__prettyFormat--disabled and euiDatePopoverButton-disabled

disabled super date picker

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@cchaos
Copy link
Contributor

cchaos commented Jul 19, 2019

PR4U: chandlerprall#9

cchaos and others added 3 commits July 22, 2019 09:21
@chandlerprall
Copy link
Contributor Author

Thanks @cchaos !!

@chandlerprall chandlerprall marked this pull request as ready for review July 22, 2019 16:23
thompsongl
thompsongl approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally in the docs

ryankeairns
ryankeairns approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as I would expect and looks good visually.

@chandlerprall chandlerprall merged commit 08b6749 into elastic:master Jul 26, 2019
@chandlerprall chandlerprall deleted the feature/2081-disablable-superdatepicker branch July 26, 2019 18:14
@chandlerprall chandlerprall mentioned this pull request Jul 30, 2019
Merged
3 tasks
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
@chandlerprall @thompsongl
Add isDisabled prop to EuiSuperDatePicker (elastic#2139)
7580ac7 
* initial disabling

* Allow EuiSuperDatePicker to be disabled via isDisabled prop

* Styling for disabled states

- Had to also add a `isDisabled` prop to EuiFormControlLayout

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow superdatepicker to be disabled
4 participants
@chandlerprall @cchaos @ryankeairns @thompsongl