Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded EUI 13.0.0 -> 13.1.1 #42298

Merged
merged 5 commits into from
Aug 2, 2019
Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 30, 2019

Summary

Updates to the latest EUI; observed snapshot changes were expected:

  • EuiDatePicker has a new default prop, isDisabled={false}
  • aria-describedby no longer applied to tooltip buttons unless tooltip is visible
  • EuiFilePicker's styling has been updated

13.1.1

Bug fixes

  • Fixed EuiMutationObserver errors in IE11 by conditionally setting the attributes observer option according to the new spec (#2180)
  • Fixed error message when an I18n mapping is a formatting function with no values provided. (#2182)

13.1.0

  • Added partial glyph to EuiIcon (#2152)
  • Added tall, fullWidth, and isInvalid props to EuiFilePicker (#2145)
  • Added exports for react-beautiful-dnd interfaces used by EUI components (#2173)
  • Added isDisabled prop & styles to EuiSuperDatePicker (#2139)
  • Added responsiveColumn option to type prop of EuiDescriptionList (#2166)
  • Removed <use> and <def> from svg icons (#2162)

Bug fixes

  • Fixed invalid aria-desribedby values set by EuiToolTip (#2156)
  • Added "center" as an acceptable value to EuiBasicTable's align proptype (#2158)
  • Fixed .eui-textBreakWord utility class to be cross-browser compatible (#2157)
  • Fixed truncation and z-index of EuiFilePicker (#2145)
  • Fixed EuiNavDrawer's support for flyout groups in production/minified builds (#2178)
  • Fixed width overflow of EuiModal (#2164)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 :Design labels Jul 30, 2019
@chandlerprall chandlerprall requested review from a team as code owners July 30, 2019 20:22
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down and check over changes.

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@chandlerprall chandlerprall changed the title Upgraded EUI 13.0.0 -> 13.1.0 Upgraded EUI 13.0.0 -> 13.1.1 Jul 31, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@chandlerprall
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas updated snapshots look good

@chandlerprall
Copy link
Contributor Author

@elastic/ml-ui could I get a review please?

@thompsongl thompsongl self-requested a review August 1, 2019 15:38
@thompsongl
Copy link
Contributor

Fixed EuiMutationObserver errors in IE11 by conditionally setting the attributes observer option according to the new spec

Do we want to remove the polyfill changes for Jest now that EUI handles it?

@chandlerprall chandlerprall requested a review from a team as a code owner August 1, 2019 18:48
@chandlerprall
Copy link
Contributor Author

Thanks @thompsongl , pushed that up

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srv/dev/jest LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chandlerprall chandlerprall merged commit da99d45 into elastic:master Aug 2, 2019
@chandlerprall chandlerprall deleted the eui-13.1.0 branch August 2, 2019 18:42
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
…-or-edit-existing-rollup-job

* 'master' of github.com:elastic/kibana: (67 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
…s_autocomplete

* 'master' of github.com:elastic/kibana: (189 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
chandlerprall added a commit that referenced this pull request Aug 5, 2019
* Upgraded EUI 13.0.0 -> 13.1.0

* Bump to 13.1.1

* Reset MutationObserver polyfill to original operation

* Reset x-pack's MutationObserver polyfill to original operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants