Update TS error-guard's text to be meaningful #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
commented
Jul 31, 2019
| @@ -98,10 +98,7 @@ export const EuiStat: FunctionComponent< | |||
| let titleText; | |||
| if (isLoading) { | |||
| titleText = ( | |||
| // EuiI18n has trouble with the string setting | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
these ignores are no longer needed, as EuiI18n's TS defs were updated to better support this setup
3 tasks
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Update TS error-guard's text to be meaningful * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provides a better error message when an i18n mapping is defined as a formatting function but no values were provided.
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes