Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-compile accessibility icon; remove default titling from EuiIcon #2632

Merged
merged 5 commits into from
Dec 12, 2019
Merged

Re-compile accessibility icon; remove default titling from EuiIcon #2632

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df6f9ea
Re-compile accessibility icon; remove default titling from EuiIcon
chandlerprall Dec 11, 2019
70c209d
changelog
chandlerprall Dec 11, 2019
fa72738
Update EuiIcon logic for when to set aria-hidden
chandlerprall Dec 11, 2019
417fe17
Merge branch 'master' into remove-euiicon-default-titles
chandlerprall Dec 12, 2019
bbe223b
fix changelog entry
chandlerprall Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `17.1.0`.
**Bug fixes**

- Removed `EuiIcon` default titles ([#2632](https://github.com/elastic/eui/pull/2632))

## [`17.1.0`](https://github.com/elastic/eui/tree/v17.1.0)

Expand Down
11 changes: 0 additions & 11 deletions src/components/accordion/__snapshots__/accordion.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,13 @@ exports[`EuiAccordion behavior closes when clicked twice 1`] = `
>
<EuiIconEmpty
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
focusable="false"
role="img"
style={null}
title=""
>
<svg
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
focusable="false"
height={16}
Expand Down Expand Up @@ -110,16 +107,13 @@ exports[`EuiAccordion behavior opens when clicked once 1`] = `
>
<EuiIconEmpty
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon euiAccordion__icon-isOpen"
focusable="false"
role="img"
style={null}
title=""
>
<svg
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon euiAccordion__icon-isOpen"
focusable="false"
height={16}
Expand Down Expand Up @@ -182,7 +176,6 @@ exports[`EuiAccordion is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -226,7 +219,6 @@ exports[`EuiAccordion props buttonContent is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -274,7 +266,6 @@ exports[`EuiAccordion props buttonContentClassName is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -320,7 +311,6 @@ exports[`EuiAccordion props extraAction is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -371,7 +361,6 @@ exports[`EuiAccordion props initialIsOpen is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiAccordion__icon euiAccordion__icon-isOpen"
focusable="false"
height="16"
Expand Down
3 changes: 0 additions & 3 deletions src/components/badge/__snapshots__/badge.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ exports[`EuiBadge props iconSide left is rendered 1`] = `
</span>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--small euiIcon-isLoading euiBadge__icon"
focusable="false"
height="16"
Expand All @@ -243,7 +242,6 @@ exports[`EuiBadge props iconSide right is rendered 1`] = `
</span>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--small euiIcon-isLoading euiBadge__icon"
focusable="false"
height="16"
Expand All @@ -270,7 +268,6 @@ exports[`EuiBadge props iconType is rendered 1`] = `
</span>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--small euiIcon-isLoading euiBadge__icon"
focusable="false"
height="16"
Expand Down
1 change: 0 additions & 1 deletion src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ exports[`CollapsedItemActions render 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
height="16"
Expand Down
9 changes: 0 additions & 9 deletions src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,16 +387,13 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
>
<EuiIconEmpty
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
focusable="false"
role="img"
style={null}
title=""
>
<svg
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
focusable="false"
height={16}
Expand Down Expand Up @@ -472,16 +469,13 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
>
<EuiIconEmpty
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
role="img"
style={null}
title=""
>
<svg
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
height={16}
Expand Down Expand Up @@ -616,16 +610,13 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
>
<EuiIconEmpty
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
role="img"
style={null}
title=""
>
<svg
aria-hidden={true}
aria-label=""
className="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
height={16}
Expand Down
3 changes: 0 additions & 3 deletions src/components/button/__snapshots__/button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ exports[`EuiButton props iconSide left is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButton__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -194,7 +193,6 @@ exports[`EuiButton props iconSide right is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButton__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -222,7 +220,6 @@ exports[`EuiButton props iconType is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButton__icon"
focusable="false"
height="16"
Expand Down
3 changes: 0 additions & 3 deletions src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ exports[`EuiButtonEmpty props iconSide left is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -179,7 +178,6 @@ exports[`EuiButtonEmpty props iconSide right is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -207,7 +205,6 @@ exports[`EuiButtonEmpty props iconType is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
focusable="false"
height="16"
Expand Down
1 change: 0 additions & 1 deletion src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ exports[`EuiButtonIcon props iconType is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
height="16"
Expand Down
1 change: 0 additions & 1 deletion src/components/call_out/__snapshots__/call_out.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ exports[`EuiCallOut props iconType is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiCallOutHeader__icon"
focusable="false"
height="16"
Expand Down
1 change: 0 additions & 1 deletion src/components/card/__snapshots__/card.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ exports[`EuiCard props icon 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon--app euiIcon-isLoading myIconClass euiCard__icon"
focusable="false"
height="16"
Expand Down
1 change: 0 additions & 1 deletion src/components/card/__snapshots__/card_select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ exports[`EuiCardSelect props isSelected 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonEmpty__icon"
focusable="false"
height="16"
Expand Down
2 changes: 0 additions & 2 deletions src/components/code/__snapshots__/code_block.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ console.log(some);
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -140,7 +139,6 @@ console.log(some);
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonIcon__icon"
focusable="false"
height="16"
Expand Down
15 changes: 0 additions & 15 deletions src/components/color_picker/__snapshots__/color_picker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ exports[`renders EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -61,7 +60,6 @@ exports[`renders EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -117,7 +115,6 @@ exports[`renders EuiColorPicker with a color swatch when color is defined 1`] =
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -139,7 +136,6 @@ exports[`renders EuiColorPicker with a color swatch when color is defined 1`] =
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -194,7 +190,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is "" 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -216,7 +211,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is "" 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -271,7 +265,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is null 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -293,7 +286,6 @@ exports[`renders EuiColorPicker with an empty swatch when color is null 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -349,7 +341,6 @@ exports[`renders compressed EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -371,7 +362,6 @@ exports[`renders compressed EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -428,7 +418,6 @@ exports[`renders disabled EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -450,7 +439,6 @@ exports[`renders disabled EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -506,7 +494,6 @@ exports[`renders fullWidth EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand All @@ -528,7 +515,6 @@ exports[`renders fullWidth EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -768,7 +754,6 @@ exports[`renders readOnly EuiColorPicker 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down
2 changes: 0 additions & 2 deletions src/components/combo_box/__snapshots__/combo_box.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ exports[`EuiComboBox is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down Expand Up @@ -267,7 +266,6 @@ exports[`props options list is rendered 1`] = `
>
<svg
aria-hidden="true"
aria-label=""
class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
focusable="false"
height="16"
Expand Down
Loading