Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed moz border on focus from EuiSelect #3178

Closed
wants to merge 1 commit into from
Closed

Removed moz border on focus from EuiSelect #3178

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2020 •
edited by ghost
Loading

Summary

Fixes #3171

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost
Copy link
Author

ghost commented Mar 26, 2020

@snide please review.

@miukimiu
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3178/

@snide snide self-requested a review March 26, 2020 20:42
@ghost
Copy link
Author

ghost commented Mar 27, 2020

@snide please review.

@ghost
Copy link
Author

ghost commented Mar 28, 2020 •
edited by ghost
Loading

The focus has been removed but there is another problem arising in dark mode. Needs a little bit of correction by changing the style differently for different modes. Will do that in quick succession.

cchaos
cchaos reviewed Mar 30, 2020
View reviewed changes
src/components/form/select/_select.scss
@@ -38,4 +38,8 @@
color: $euiTextColor;
background: transparent;
}
&:-moz-focusring {
color: transparent;
text-shadow: 0 0 0 #000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to use SASS vars for colors as you see above in the IE fix.

You should also turn linting on in your editor and not skip the pre-commit hooks which would have alerted you to the errors here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @cchaos

@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2020

Also, in order for us to better review this PR, please provide a detailed summary as to your approach to fixing the issue. You will also need to add a Changelog entry. You can follow the guidelines in the Contributing doc.

@ghost ghost mentioned this pull request Mar 30, 2020
Merged
9 tasks
@ghost
Copy link
Author

ghost commented Mar 30, 2020

@cchaos please see #3197

@ghost ghost closed this Mar 30, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiSelect should remove moz border on focus
3 participants
@kibanamachine @miukimiu @cchaos