Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed moz border on focus from EuiSelect. #3197

Merged
merged 6 commits into from Mar 30, 2020
Merged

Removed moz border on focus from EuiSelect. #3197

merged 6 commits into from Mar 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 30, 2020

Description

Old - #3178

Fixes #3171

GIF

2-2

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost ghost mentioned this pull request Mar 30, 2020
Closed
9 tasks
@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2020

Can you please describe the path you took to find this CSS solution? Why does it need a transparent text color but with a text-shadow?

@ghost
Copy link
Author

ghost commented Mar 30, 2020 •
edited by ghost
Loading

Mozilla uses text color to determine the color of the dotted border, so we need to use color as transparent for it but for text to be visible, the text shadow should be completely black.

cchaos
cchaos suggested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to add a Changelog entry. You can follow the guidelines in the Contributing doc.

src/components/form/select/_select.scss Outdated Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2020

Jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3197/

cchaos
cchaos approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, just a nit in regards to language in the changelog. I'll commit and merge.

Thanks @walter-ind!

CHANGELOG.md Outdated Show resolved Hide resolved
@cchaos cchaos merged commit 88f1041 into elastic:master Mar 30, 2020
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiSelect should remove moz border on focus
2 participants
@kibanamachine @cchaos