Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Reverse asc and desc labels for datetime schema #4733

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 19, 2021

Summary

Closes #4712, in which it was discovered that the sort labels for datetime schema were inverted.

For dates, ascending means that earlier values precede later ones (e.g., 1/1/2020 will sort ahead of 1/1/2021)

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs and playground toggles
- [ ] Added documentation

- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately

- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@myasonik
Copy link
Contributor

I wonder if we do need to change the token names for these string?

Because (I assume) Kibana's i18n process won't know that the string behind these tokens changed (if you change a string in Kibana, you have to manually delete the translations for them to be re-done) so they'll potentially never get updated.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4733/

@thompsongl
Copy link
Contributor Author

thompsongl commented Apr 19, 2021

Because (I assume) Kibana's i18n process won't know that the string behind these tokens changed

We'll need to remember to update https://github.com/elastic/kibana/blob/master/src/core/public/i18n/i18n_eui_mapping.tsx with the new labels, but changing the token name isn't necessary.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4733/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4733/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiDataGrid] Date Sort Order is Reversed
4 participants