-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Reverse asc and desc labels for datetime
schema
#4733
Conversation
I wonder if we do need to change the token names for these string? Because (I assume) Kibana's i18n process won't know that the string behind these tokens changed (if you change a string in Kibana, you have to manually delete the translations for them to be re-done) so they'll potentially never get updated. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4733/ |
We'll need to remember to update https://github.com/elastic/kibana/blob/master/src/core/public/i18n/i18n_eui_mapping.tsx with the new labels, but changing the token name isn't necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦑
Preview documentation changes for this PR: https://eui.elastic.co/pr_4733/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4733/ |
Summary
Closes #4712, in which it was discovered that the sort labels for
datetime
schema were inverted.For dates, ascending means that earlier values precede later ones (e.g., 1/1/2020 will sort ahead of 1/1/2021)
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes