Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Reverse asc and desc labels for datetime schema #4733

Merged
merged 5 commits into from
Apr 20, 2021
Merged

[EuiDataGrid] Reverse asc and desc labels for datetime schema #4733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8aedf50
date sort text swap
thompsongl Apr 19, 2021
f70348c
tokens
thompsongl Apr 19, 2021
2baa927
Merge branch 'master' into 4712-sort
thompsongl Apr 20, 2021
643d475
CL
thompsongl Apr 20, 2021
a623baf
Merge branch 'master' into 4712-sort
thompsongl Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

**Bug fixes**

- Fixed `EuiInMemoryTable` `pagination` prop to update visible items when changed ([#4714](https://github.com/elastic/eui/pull/4714))
- Fixed `EuiInMemoryTable` `pagination` prop to update visible items when changed ([#4714](https://github.com/elastic/eui/pull/4714))
- Fixed a bug in `EuiFilePicker` where the HTML input was being shown when `disabled` ([#4738](https://github.com/elastic/eui/pull/4738))
- Fixed inverted asc and desc labels for `EuiDataGrid` `datetime` schema ([#4733](https://github.com/elastic/eui/pull/4733))

## [`32.1.0`](https://github.com/elastic/eui/tree/v32.1.0)

Expand Down
4 changes: 2 additions & 2 deletions src/components/datagrid/data_grid_schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,10 @@ export const schemaDetectors: EuiDataGridSchemaDetector[] = [
},
icon: 'tokenDate',
sortTextAsc: (
<EuiI18n token="euiDataGridSchema.dateSortTextAsc" default="New-Old" />
<EuiI18n token="euiDataGridSchema.dateSortTextAsc" default="Old-New" />
),
sortTextDesc: (
<EuiI18n token="euiDataGridSchema.dateSortTextDesc" default="Old-New" />
<EuiI18n token="euiDataGridSchema.dateSortTextDesc" default="New-Old" />
),
},
{
Expand Down