[EuiIcon] Add crossInCircle glyph
#7924
Conversation
|
Hi @ek-so! Could you please add and commit a changelog item for this PR? You can create it by running |
There was a problem hiding this comment.
Thanks for the PR, @ek-so! I left you some small comments for your initial review. Let me know if you have any questions.
There was a problem hiding this comment.
It looks as though the circle's stroke is slightly less than 1px. Any chance we could make it exactly 1px to avoid any subpixel blurriness?
There was a problem hiding this comment.
Thank Michael, sorry for all that discrepancies! Honestly, I just created my form based on outlined plus we already have. Considering other outlined icons we have, I'm a bit lost which template to stick to. You can see, these +/- differ from what's on your screenshot. It means we'll have to change all those outlined icons later too, right @MichaelMarcialis?
Also, the cross inside looks like also not 1px folk. Is in intentionally more for filled icon? Isn't it blurry then? Maybe we can also correct this glyph, while we're here?
There was a problem hiding this comment.
Yeah, all good points. These are just some of the many discrepancies and inconsistencies we need to correct in general in the icon library.
Anyway, for the purposes of this PR, I'd suggest proceeding with the comment recommendations, even they create inconsistency with some of those similar examples you shared. We'll eventually update those other ones to match. Alternatively, if you have the time and willingness, please do feel free to adjust them as part of this PR. But no pressure. Assuming we continue to maintain our custom icon library, I have it on my to-do list to make these sorts of adjustments in the near future.
There was a problem hiding this comment.
I noticed that the endpoints for the x symbol don't sit perfectly on the pixel grid, unlike its sister crossInCircleFilled icon. Would you mind adjusting so that the endpoints are the same as crossInCircleFilled?
There was a problem hiding this comment.
We typically try to minify and strip any non-essential information from the SVG files. In this case, we could remove all fill attributes, the g container, and the defs. Doing so would yield SVG code similar to this:
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
<path d="m8.755 8 2.64 2.641a.534.534 0 1 1-.754.755L8 8.755l-2.641 2.64a.533.533 0 1 1-.755-.754L7.244 8l-2.64-2.641a.534.534 0 1 1 .755-.755l2.64 2.641 2.642-2.64a.534.534 0 1 1 .755.754L8.755 8Zm4.904-5.66c3.12 3.121 3.12 8.199 0 11.32-3.12 3.12-8.198 3.12-11.318 0C-.78 10.538-.78 5.46 2.34 2.34c3.12-3.12 8.198-3.12 11.319 0Zm-.665.666a7.062 7.062 0 1 0-9.988 9.987 7.062 7.062 0 0 0 9.988-9.987Z"/>
</svg>
After making updates based on previous comments, mind scrubbing these extraneous elements from your updated SVG file?
There was a problem hiding this comment.
Can we change this file's name from crossInCircle.svg to cross_in_circle.svg? I know there's currently a mix of snake and camel case in the SVGs folder currently, but we'll be updating them all to snake case going forward.
| @@ -79,6 +79,7 @@ export const typeToPathMap = { | |||
| createSingleMetricJob: 'ml_create_single_metric_job', | |||
| cross: 'cross', | |||
| crossClusterReplicationApp: 'app_cross_cluster_replication', | |||
| crossInCircle: 'crossInCircle', | |||
There was a problem hiding this comment.
Once the SVG file name is update, you'll also need to update this.
| crossInCircle: 'crossInCircle', | |
| crossInCircle: 'cross_in_circle', |
|
Hey @MichaelMarcialis, thanks for your comments! To summarize:
|
|
@MichaelMarcialis is this PR good to go from a designer point of view? |
@MichaelMarcialis hey hey, is it all fine by you? |
There was a problem hiding this comment.
Thanks for making those updates, @ek-so! Looks great. I left two small comments for your review, but nothing worth holding you up over. Assuming you can address those two suggestions to remove the fill attribute and g element, I'll go ahead and approve now.
💚 Build Succeeded
History
|
`v95.5.0` ⏩ `v95.6.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.6.0`](https://github.com/elastic/eui/releases/v95.6.0) - Updated `EuiIcon` with a new `crossInCircle` glyph ([#7924](elastic/eui#7924)) **Bug fixes** - Fixed `EuiEmptyPrompt` to correctly collapse and expand responsively when used with custom breakpoints larger than the default `xl` breakpoint ([#7935](elastic/eui#7935)) **Accessibility** - Improved the experience of `EuiModal` by ensuring nested `EuiPopover` closes on `Escape` keypress instead of the modal ([#7939](elastic/eui#7939)) **CSS-in-JS conversions** - Converted `EuiDatePicker` to Emotion ([#7937](elastic/eui#7937)) - Removed `$euiDatePickerCalendarWidth` - Removed `$euiDatePickerPadding` - Removed `$euiDatePickerGap` - Removed `$euiDatePickerCalendarColumns` - Removed `$euiDatePickerButtonSize` - Removed `$euiDatePickerMinControlWidth` - Removed `$euiDatePickerMaxControlWidth` - Removed `@mixin datePickerCaret` - Removed `@mixin datePickerArrow`
Summary
We need an outlined icon variant for cross (agreed with @MichaelMarcialis here)
QA
General checklist