Add Boolean field formatter #7935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with Boolean values being displayed as 0 and 1 instead of as 'true' and 'false' in the visualizations. Also added this as the default formatter for Boolean field types.
Also trim & lowercase text input.
|
jenkins, test this |
|
|
||
| Bool.id = 'boolean'; | ||
| Bool.title = 'Boolean'; | ||
| Bool.fieldType = ['boolean']; |
There was a problem hiding this comment.
thoughts on making this available for string and number fields too?
There was a problem hiding this comment.
OK. That makes sense if people want to display a value as boolean, but not necessarily map it as such in their index.
|
Looking good, two small comments above |
Improve string conversion. Objects will now be serialized.
|
LGTM |
|
LGTM |
|
@BigFunger thanks for reviewing! FYI, I created #7975, to discuss this issue. |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Add Boolean field formatter Former-commit-id: a33b364
cee-chen
added a commit
that referenced
this pull request
Aug 5, 2024
`v95.5.0` ⏩ `v95.6.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.6.0`](https://github.com/elastic/eui/releases/v95.6.0) - Updated `EuiIcon` with a new `crossInCircle` glyph ([#7924](elastic/eui#7924)) **Bug fixes** - Fixed `EuiEmptyPrompt` to correctly collapse and expand responsively when used with custom breakpoints larger than the default `xl` breakpoint ([#7935](elastic/eui#7935)) **Accessibility** - Improved the experience of `EuiModal` by ensuring nested `EuiPopover` closes on `Escape` keypress instead of the modal ([#7939](elastic/eui#7939)) **CSS-in-JS conversions** - Converted `EuiDatePicker` to Emotion ([#7937](elastic/eui#7937)) - Removed `$euiDatePickerCalendarWidth` - Removed `$euiDatePickerPadding` - Removed `$euiDatePickerGap` - Removed `$euiDatePickerCalendarColumns` - Removed `$euiDatePickerButtonSize` - Removed `$euiDatePickerMinControlWidth` - Removed `$euiDatePickerMaxControlWidth` - Removed `@mixin datePickerCaret` - Removed `@mixin datePickerArrow`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue of booleans not being displayed as
trueorfalsein the legend or on the axes of visualizations (#7898)Note that booleans already displayed as
trueandfalseon the Discover page. However, this was due to server-side formatting of ES.