[Theme] Base theme setup #8030
Merged
[Theme] Base theme setup #8030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
2 times, most recently
from
cd61810
to
d19f6c1
Compare
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
8 times, most recently
from
ab1ae64
to
1596ae7
Compare
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
from
b81a336
to
7486e9a
Compare
- externally created, compiled and imported themes don't pass the class check anymore we can check for the shape additionally
- theme contains only cloned values from current theme
- ensures current state EUI
-removes circle dependency on main eui
build: ensure sass files are added to packed sub packages
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
from
e64597a
to
ce4e8e1
Compare
mgadewoll
changed the title
mgadewoll
force-pushed
the
eui-theme/124-add-new-theme
branch
from
62ad98d
to
2532104
Compare
mgadewoll
commented
Oct 9, 2024
| @@ -253,6 +256,8 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@elastic/datemath": "^5.0.2", | |||
| "@elastic/eui-theme-borealis": "0.0.1", | |||
| "@elastic/eui-theme-common": "0.0.1", | |||
There was a problem hiding this comment.
ℹ️ The theme-common package is added as peerDependency for now while it's not actually released yet. Once released we should add it as actual dependency.
mgadewoll
commented
Oct 9, 2024
| @@ -16,8 +16,9 @@ | |||
| ], | |||
| "scripts": { | |||
| "start": "cross-env BABEL_MODULES=false webpack serve --config=src-docs/webpack.config.js", | |||
| "build:workspaces": "yarn workspaces foreach -Rti --from @elastic/eui-theme-common run build && yarn workspaces foreach -Rti --from @elastic/eui --exclude @elastic/eui --exclude @elastic/eui-theme-common run build", | |||
There was a problem hiding this comment.
❓ I'm wondering if we want to move this also to the root of our monorepo to have a global script to run initially similar to yarn, Wdyt?
mgadewoll
commented
Oct 9, 2024
| "license": "SEE LICENSE IN LICENSE.txt", | ||
| "scripts": { | ||
| "build:clean": "rimraf lib/", | ||
| "build": "yarn build:clean && yarn build:compile && yarn build:compile:cjs && yarn build:types", |
There was a problem hiding this comment.
ℹ️ Currently there are no watchers setup yet to listen to changes in these standalone packages. That means that - for now - we need to manually update when e.g. running Storybook or docs.
This should be added for devX but is likely going to happen as a follow-up task.
tkajtoch
reviewed
Oct 9, 2024
💔 Build Failed
Failed CI StepsHistory
|
tkajtoch
approved these changes
Oct 23, 2024
mgadewoll
added a commit
that referenced
this pull request
Oct 23, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Oct 31, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 8, 2024
mgadewoll
added a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #124
Important
This PR is currently still in
Draftmode, as it needs alignment on some package/dependency specific setups/architectural choices.📖 See additional information here.
QA
/eui: runbuild:workspacesto build workspace dependencies then check that our common development tools/scripts work as expectedyarn storybookandyarn build-storybookyarn startandyarn build-docs/website: runbuild:workspacesand then test that EUI+ docs works as expected viayarn startandyarn buildDeployments & theme switcher testing
By default the theme switcher is only enabled for
developmentenvironments.Storybook: https://eui.elastic.co/pr_8030/storybook/?path=/story/navigation-euibutton--playground
EUI docs: https://eui.elastic.co/pr_8030/
EUI+: https://eui.elastic.co/pr_8030/new-docs/