-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE][DRAFT] Theme color setup #8049
Closed
mgadewoll
wants to merge
24
commits into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/125-color-matrix-setup
Closed
[DO NOT MERGE][DRAFT] Theme color setup #8049
mgadewoll
wants to merge
24
commits into
elastic:eui-theme/borealis
from
mgadewoll:eui-theme/125-color-matrix-setup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- externally created, compiled and imported themes don't pass the class check anymore we can check for the shape additionally
- theme contains only cloned values from current theme
- ensures current state EUI
-removes circle dependency on main eui
build: ensure sass files are added to packed sub packages
- this is a first step, once the overall path si defined we either need to continue moving out more or reverse this partially
💚 Build Succeeded
History
|
ℹ️ Closing this Draft testing PR in favor of opening up a new clean branch once the initial setup PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR is currently still in
Draft
mode. It's based on this previous PR and relies on that one to be aligned and merged first.🚧 TBA 🚧
Storybook: https://eui.elastic.co/pr_8049/storybook/
EUI docs: https://eui.elastic.co/pr_8049/#/
EUI+: https://eui.elastic.co/pr_8049/new-docs/
QA
🚧 TBA 🚧