Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE Fixes (mostly flex box) #973

Merged
merged 3 commits into from
Jul 6, 2018
Merged

IE Fixes (mostly flex box) #973

merged 3 commits into from
Jul 6, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 6, 2018

  • Fixed modal overflow issue
  • Fixed flex wrapping elements in docs and added utility class (.euiIEFlexWrapFix) for consumers
  • Fixed image shrink issues (fixes Empty space below image on IE #971)
  • Fixed home card layout that was still using <Link>. I added the secureRel stuff to EuiCard to support app linking.
  • Added some callouts to mention where IE flex bugs may occur (especially for when a generalized fix cannot be implemented)

cchaos added 2 commits July 6, 2018 15:10
- Fixed modal overflow issue
- Fixed flex wrapping elements in docs and added utility class (`.euiIEFlexWrapFix`) for consumers
- Fixed image shrink issues (fixes elastic#971)
- Fixed home card layout that was still using `<Link>`. I added the `secureRel` stuff to `EuiCard` to support app linking.
- Added some callouts to mention where IE flex bugs may occur (especially for when a generalized fix cannot be implemented)
@cchaos cchaos requested a review from chandlerprall July 6, 2018 19:19
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; code review & tested examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty space below image on IE
2 participants