-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Fix ECS import method #5106
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0942827
Fix ECS import method
kfirpeled 8d64bb4
fixed pr no. in changelog
kfirpeled d2cc334
updated format version, ECS to 8.6, ECS ingested version, and other f…
kfirpeled 4c5a368
moved timestamp declaration to base-fields
kfirpeled faacfd5
Merge branch 'main' into cspm/fix-ecs-import
kfirpeled File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| dependencies: | ||
| ecs: | ||
| reference: [email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 0 additions & 89 deletions
89
packages/cloud_security_posture/data_stream/findings/fields/ecs.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,213 +1,124 @@ | ||
| - name: "@timestamp" | ||
| external: ecs | ||
| type: date | ||
| - name: agent.ephemeral_id | ||
| external: ecs | ||
| type: keyword | ||
| - name: agent.id | ||
| external: ecs | ||
| type: keyword | ||
| - name: agent.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: agent.type | ||
| external: ecs | ||
| type: keyword | ||
| - name: agent.version | ||
| external: ecs | ||
| type: keyword | ||
| - name: ecs.version | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.agent_id_status | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.ingested | ||
| external: ecs | ||
| type: date | ||
| - name: file.accessed | ||
| external: ecs | ||
| type: date | ||
| - name: file.ctime | ||
| external: ecs | ||
| type: date | ||
| - name: file.directory | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.extension | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.gid | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.group | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.inode | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.mode | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.mtime | ||
| external: ecs | ||
| type: date | ||
| - name: file.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.owner | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.path | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.size | ||
| external: ecs | ||
| type: long | ||
| - name: file.type | ||
| external: ecs | ||
| type: keyword | ||
| - name: file.uid | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.architecture | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.containerized | ||
| external: ecs | ||
| type: boolean | ||
| - name: host.hostname | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.ip | ||
| external: ecs | ||
| type: ip | ||
| - name: host.mac | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.codename | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.family | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.full | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.kernel | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.platform | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.type | ||
| external: ecs | ||
| type: keyword | ||
| - name: host.os.version | ||
| external: ecs | ||
| type: keyword | ||
| - name: message | ||
| external: ecs | ||
| type: match_only_text | ||
| - name: process.args | ||
| external: ecs | ||
| type: keyword | ||
| - name: process.args_count | ||
| external: ecs | ||
| type: long | ||
| - name: process.command_line | ||
| external: ecs | ||
| type: wildcard | ||
| - name: process.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: process.parent.pid | ||
| external: ecs | ||
| type: long | ||
| - name: process.parent.start | ||
| external: ecs | ||
| type: date | ||
| - name: process.pgid | ||
| external: ecs | ||
| type: long | ||
| - name: process.pid | ||
| external: ecs | ||
| type: long | ||
| - name: process.start | ||
| external: ecs | ||
| type: date | ||
| - name: process.title | ||
| external: ecs | ||
| type: keyword | ||
| - name: process.uptime | ||
| external: ecs | ||
| type: long | ||
| - name: rule.benchmark.id | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.benchmark.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.benchmark.version | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.description | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.id | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.section | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.tags | ||
| external: ecs | ||
| type: keyword | ||
| - name: rule.version | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.category | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.created | ||
| external: ecs | ||
| type: date | ||
| - name: event.ingested | ||
| external: ecs | ||
| type: date | ||
| - name: event.id | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.kind | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.sequence | ||
| external: ecs | ||
| type: long | ||
| - name: event.outcome | ||
| external: ecs | ||
| type: keyword | ||
| - name: event.type | ||
| external: ecs | ||
| type: keyword | ||
| - name: orchestrator.cluster.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: cloud.account.id | ||
| external: ecs | ||
| type: keyword | ||
| - name: cloud.account.name | ||
| external: ecs | ||
| type: keyword | ||
| - name: cloud.provider | ||
| external: ecs | ||
| type: keyword | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host.os.codenameandhost.containerizedare not part of ECS atmelastic/ecs#294
elastic/ecs#1512
Do you think it's worth adding them as a custom field? and for the sake of backward compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the field type does not change between the type you set manually and the type the ECS field ends up being its fine to map them. If its unsure then we should get confirmation about the preferred type first.