[cisco_ios]: escape hyphen inside regex char list

[pkoutsovasilis]

Proposed commit message

After tackling this issue, a respective PR was created to elastic-package to mainstream the detection of similar warnings. Thus this PR fixes the following similar to the former issue regex-related warning for cisco_ios

character class has '-' without escape

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

Related issues

N/A

Screenshots

N/A

[elasticmachine]

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

[elasticmachine]

🚀 Benchmarks report

Package cisco_ios 👍(1) 💚(0) 💔(0)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
log	0	637.76	637.76 ( - %)	👍

[jrmolin]

one question, not going to block for an answer.

[dwhyrock]

From the report:

Data stream	Previous EPS	New EPS	Diff (%)	Result
log	2207.51	545.85	-1661.66 (-75.27%)	💔

Is EPS "events per second"? And should we be concerned with the numbers here?

[pkoutsovasilis]

From the report:

Data stream Previous EPS New EPS Diff (%) Result
log 2207.51 545.85 -1661.66 (-75.27%) 💔
Is EPS "events per second"? And should we be concerned with the numbers here?

hmmm not sure to be honest I just escaped a hyphen I didn't expect such a massive impact on perf 🤷‍♂️

[taylor-swanson]

I pulled the changes locally and ran benchmarks myself. I'm not noticing any notable differences between the current version in main and this one. If anything the timing seems slightly tighter and ever so slightly faster with this change than main. Unfortunately, the benchmark tool doesn't give anything more specific for stats (percentiles, standard deviation, etc) so that's all based on "feel".

I'm not sure exactly how the CI runs the benchmarks, but if it's only once, then unfortunately there's a chance that it has a bad run and show a large "change", when in reality it could run it again and show that it's the same or faster.

[pkoutsovasilis]

/test benchmark fullreport

[pkoutsovasilis]

So @taylor-swanson @dwhyrock @jrmolin, after having a look at the CI steps, the elastic-package benchmark is invoked only once here. The baseline benchmark results are uploaded from main, so when a commit is merged the affected packages are detected and for ones found, benchmark is run and pushed in the respective buildkite artifact. That said, I did the same practice as Taylor in his comments and my local running benchmark report is not exhibiting such a substantial perf difference. However, I did push a commit that reverts the fix and just does a dummy change to cause the benchmarking to execute and the performance hindering is gone 🤷‍♂️ Any more ideas?

[pkoutsovasilis]

/test benchmark fullreport

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 042f979

History

• 💚 Build #10386 succeeded 042f979
• 💚 Build #10383 succeeded 0ffda87
• 💚 Build #10382 succeeded 438701e5d756e7c64f5a8615d5cf2333aff19aba
• 💚 Build #10359 succeeded c1f034b
• 💚 Build #10347 succeeded c1f034b

cc @pkoutsovasilis

[elastic-sonarqube]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[pkoutsovasilis]

🚀 Benchmarks report

Package cisco_ios 👍(1) 💚(0) 💔(0)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 0 637.76 637.76 ( - %) 👍

I think somehow all my tweaking and messing around managed to mess up with the benchmarking. In an attempt to recover that, I am gonna close this one and open a new one with my experiments

[mergify]

⚠️ The sha of the head commit of this PR conflicts with #9578. Mergify cannot evaluate rules on this PR. ⚠️