[cisco_ios]: escape hyphen inside regex char list

[pkoutsovasilis]

Proposed commit message

After tackling this issue, a respective PR was created to elastic-package to mainstream the detection of similar warnings. Thus this PR fixes the following similar to the former issue regex-related warning for cisco_ios

character class has '-' without escape

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

Related issues

N/A

Screenshots

N/A

[elasticmachine]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[elastic-sonarqube]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 3cea41e

History

• 💚 Build #10389 succeeded 042f979

[elasticmachine]

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

[pkoutsovasilis]

@jrmolin @dwhyrock @taylor-swanson apparently if I don't escape the - in the char list and I move to the end right before the ] which is a special regex case and you don't have to escape the - benchmark results do not show a perf degradation 🥲

[gogochan]

LGTM

[dwhyrock]

That's a pretty interesting find. Nice work!

[taylor-swanson]

@jrmolin @dwhyrock @taylor-swanson apparently if I don't escape the - in the char list and I move to the end right before the ] which is a special regex case and you don't have to escape the - benchmark results do not show a perf degradation 🥲

I'm actually surprised that this makes a difference. I knew about moving the hyphen to the end (which is what I typically do), but I would've assume that escaping it would've compiled to the same result.