Skip to content

Commit

Permalink
Children of buttons won't capture hover events in firefox (#13015)
Browse files Browse the repository at this point in the history
* Children of buttons won't capture hover events in firefox

Fixes #12987

* Make full screen div accessible

* Remove nested aria labels
  • Loading branch information
stacey-gammon authored Jul 24, 2017
1 parent 2043cf0 commit 2f23303
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/core_plugins/kibana/public/dashboard/dashboard.html
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
<dashboard-app class="app-container dashboard-container">
<div class="fullScreenModePlaceholder">
<button
<div
aria-label="Exit full screen mode"
kbn-accessible-click
ng-if="fullScreenMode"
class="exitFullScreenMode"
ng-click="exitFullScreenMode()"
>
<span aria-hidden="true" class="exitFullScreenModeLogo"></span>
<span class="exitFullScreenModeLogo"></span>
<span class="exitFullScreenModeText">
Exit full screen
<span aria-hidden="true" class="kuiIcon fa fa-angle-left"></span>
<span class="kuiIcon fa fa-angle-left"></span>
</span>
</button>
</div>
</div>
<!-- Local nav. -->
<kbn-top-nav name="dashboard" config="topNavMenu">
Expand Down

0 comments on commit 2f23303

Please sign in to comment.