Children of buttons won't capture hover events in firefox #13015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
suggested changes
Jul 20, 2017
| @@ -1,6 +1,6 @@ | |||
| <dashboard-app class="app-container dashboard-container"> | |||
| <div class="fullScreenModePlaceholder"> | |||
| <button | |||
| <div | |||
There was a problem hiding this comment.
This will now need a tab index and aria label.
There was a problem hiding this comment.
used kbn-accessible-click, that seemed to work better, otherwise I couldn't seem to press "enter" once it was highlighted.
There was a problem hiding this comment.
👍 Good thinking @snide. kbn-accessible-click adds those properties under the hood, so good call @stacey-gammon.
| @@ -10,7 +10,7 @@ | |||
| Exit full screen | |||
| <span aria-hidden="true" class="kuiIcon fa fa-angle-left"></span> | |||
There was a problem hiding this comment.
You can remove the aria labels here now.
…irefox-fullscreen-hover-button
snide
approved these changes
Jul 21, 2017
cjcenizal
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
Awesome! I love the attention to detail wrt adding extra info via the aria-label. It might be worth checking this with @aphelionz to make sure it actually adds the value we think it does, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12987
cc @cjcenizal