Skip to content

Commit

Permalink
[Storybook] Mute SASS mixed-decls warnings (#192648)
Browse files Browse the repository at this point in the history
## Summary

This extends #190348 to the Storybook build because it is quite noisy
there as well. Example:


https://buildkite.com/elastic/kibana-pull-request/builds/233585#0191e2ad-bc90-45f1-b375-959f3fc22b98/268-294

Remediation will be tracked at
#190345

### Testing
The Storybook build step should not have SASS deprecation warnings.
  • Loading branch information
Ikuni17 authored Sep 11, 2024
1 parent f558291 commit 94411c5
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions packages/kbn-storybook/src/webpack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,18 @@ export default ({ config: storybookConfig }: { config: Configuration }) => {
sassOptions: {
includePaths: [resolve(REPO_ROOT, 'node_modules')],
quietDeps: true,
logger: {
warn: (message: string, warning: any) => {
// Muted - see https://github.com/elastic/kibana/issues/190345 for tracking remediation
if (warning?.deprecationType?.id === 'mixed-decls') return;

if (warning.deprecation)
return process.stderr.write(
`DEPRECATION WARNING: ${message}\n${warning.stack}`
);
process.stderr.write('WARNING: ' + message);
},
},
},
},
},
Expand Down

0 comments on commit 94411c5

Please sign in to comment.