add test for unknown type / tag

x-pack/plugins/global_search_bar/public/components/search_bar.tsx

@@ -132,9 +132,9 @@ export function SearchBar({
       const rawParams = parseSearchParams(searchValue);
       const tagIds =
         taggingApi && rawParams.filters.tags
-          ? rawParams.filters.tags
-              .map((tagName) => taggingApi.ui.getTagIdFromName(tagName))
-              .filter((tagId): tagId is string => tagId !== undefined)
+          ? rawParams.filters.tags.map(
+              (tagName) => taggingApi.ui.getTagIdFromName(tagName) ?? '__unknown__'
+            )
           : undefined;
       const searchParams: GlobalSearchFindParams = {
         term: rawParams.term,

x-pack/test/functional/page_objects/navigational_search.ts

@@ -57,21 +57,27 @@ export function NavigationalSearchProvider({ getService, getPageObjects }: FtrPr
       await options[index].click();
     }
 
-    async waitForResultsLoaded() {
+    async waitForResultsLoaded(waitUntil: number = 3000) {
       await testSubjects.exists('nav-search-option');
       // results are emitted in multiple batches. Each individual batch causes a re-render of
       // the component, causing the current elements to become stale. We can't perform DOM access
       // without heavy flakiness in this situation.
       // there is NO ui indication of any kind to detect when all the emissions are done,
       // so we are forced to fallback to awaiting a given amount of time once the first options are displayed.
-      await delay(3000);
+      await delay(waitUntil);
     }
 
     async getDisplayedResults() {
       const resultElements = await testSubjects.findAll('nav-search-option');
       return Promise.all(resultElements.map((el) => this.convertResultElement(el)));
     }
 
+    async isNoResultsPlaceholderDisplayed(checkAfter: number = 3000) {
+      // see comment in `waitForResultsLoaded`
+      await delay(checkAfter);
+      return testSubjects.exists('nav-search-no-results');
+    }
+
     private async convertResultElement(resultEl: WebElementWrapper): Promise<SearchResult> {
       const labelEl = await find.allDescendantDisplayedByCssSelector(
         '.euiSelectableTemplateSitewide__listItemTitle',
@@ -85,10 +91,5 @@ export function NavigationalSearchProvider({ getService, getPageObjects }: FtrPr
     }
   }
 
-  // nav-search-popover
-  // nav-search-option
-  // euiSelectableTemplateSitewide__listItemTitle
-  // euiSelectableTemplateSitewide__optionMeta
-
   return new NavigationalSearch();
 }

x-pack/test/plugin_functional/test_suites/global_search/global_search_bar.ts

@@ -139,6 +139,18 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
         expect(results.map((result) => result.label)).to.eql(['My awesome vis (tag-4)']);
       });
+
+      it('returns no results when searching for an unknown tag', async () => {
+        await navigationalSearch.searchFor('tag:unknown');
+
+        expect(await navigationalSearch.isNoResultsPlaceholderDisplayed()).to.eql(true);
+      });
+
+      it('returns no results when searching for an unknown type', async () => {
+        await navigationalSearch.searchFor('type:unknown');
+
+        expect(await navigationalSearch.isNoResultsPlaceholderDisplayed()).to.eql(true);
+      });
     });
   });
 }

x-pack/test/plugin_functional/test_suites/global_search/global_search_providers.ts

@@ -22,7 +22,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
     }, t);
   };
 
-  describe('TOTO GlobalSearch - SavedObject provider', function () {
+  describe('GlobalSearch - SavedObject provider', function () {
     before(async () => {
       await esArchiver.load('global_search/basic');
     });