Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] [Meta] Create Rule Flow v2 #175634

Closed
11 of 12 tasks
Zacqary opened this issue Jan 25, 2024 · 2 comments
Closed
11 of 12 tasks

[RAM] [Meta] Create Rule Flow v2 #175634

Zacqary opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
8.14 candidate Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@Zacqary Zacqary added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX 8.14 candidate labels Jan 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@Zacqary Zacqary moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Rules & Alerts Management Feb 6, 2024
@Zacqary Zacqary moved this from Todo to Awaiting Triage in AppEx: ResponseOps - Rules & Alerts Management Feb 6, 2024
@Zacqary Zacqary moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Mar 5, 2024
@Zacqary Zacqary self-assigned this Mar 21, 2024
Zacqary added a commit that referenced this issue Mar 27, 2024
## Summary

Closes #179110 

This adds a series of feature flags to all plugins that are currently
using the **Rule Form Flyout**, in preparation for development of the
new Create Rule Flow V2 (#175634).

Unfortunately true Kibana feature-flagging is still not yet implemented,
so we need to implement this as a config option for every individual
affected plugin. The following `kibana.yml` config will enable the
upcoming V2 rule form:

```yaml
xpack.trigger_actions_ui.enableExperimental: ['ruleFormV2']
xpack.infra.featureFlags.ruleFormV2Enabled: true
xpack.ml.experimental.ruleFormV2.enabled: true
xpack.transform.experimental.ruleFormV2Enabled: true
xpack.legacy_uptime.experimental.ruleFormV2Enabled: true
xpack.observability.unsafe.ruleFormV2.enabled: true
xpack.slo.experimental.ruleFormV2.enabled: true
xpack.apm.featureFlags.ruleFormV2Enabled: true

discover.experimental.ruleFormV2Enabled: true
``` 

**These feature flags will not enable anything yet.** This PR is for the
sole purpose of adding these browser-enabled flags now, so that we can
reduce the amount of code committed later.

### Why feature flag every plugin?

The V1 rule form is currently exported from Triggers Actions UI. In V2,
we're moving away from this model and exporting the rule form in a KBN
package. Therefore we can't simply export the results of a single
feature flag from Triggers Actions UI, we need to signal to each
individual plugin whether it should be pulling from the new KBN package
or from the old cross-plugin export.

### Plugins affected

#### Triggers Actions UI, Infra, Observability, APM

These plugins already contained interfaces for experimental features or
feature flags, so this PR simply adds a new flag to these existing
structures.

#### Discover, ML, Transform, Uptime, SLO

These plugins did **not** have existing browser-exposed feature flag
systems, so this PR adds these interfaces. The transform plugin notably
did not yet have any config options configured at all.
@cnasikas cnasikas assigned JiaweiWu and unassigned Zacqary Apr 23, 2024
@cnasikas
Copy link
Member

cnasikas commented Nov 1, 2024

Closing as most of the tasks are done or tracked by #196235.

@cnasikas cnasikas closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.14 candidate Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

4 participants