-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] [Meta] Create Rule Flow v2 #175634
Labels
8.14 candidate
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Comments
Zacqary
added
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
8.14 candidate
labels
Jan 25, 2024
Pinging @elastic/response-ops (Team:ResponseOps) |
github-project-automation
bot
moved this to Awaiting Triage
in AppEx: ResponseOps - Rules & Alerts Management
Jan 25, 2024
Zacqary
moved this from Awaiting Triage
to Todo
in AppEx: ResponseOps - Rules & Alerts Management
Feb 6, 2024
Zacqary
moved this from Todo
to Awaiting Triage
in AppEx: ResponseOps - Rules & Alerts Management
Feb 6, 2024
Zacqary
moved this from Awaiting Triage
to In Progress
in AppEx: ResponseOps - Rules & Alerts Management
Mar 5, 2024
This was referenced Mar 21, 2024
Zacqary
added a commit
that referenced
this issue
Mar 27, 2024
## Summary Closes #179110 This adds a series of feature flags to all plugins that are currently using the **Rule Form Flyout**, in preparation for development of the new Create Rule Flow V2 (#175634). Unfortunately true Kibana feature-flagging is still not yet implemented, so we need to implement this as a config option for every individual affected plugin. The following `kibana.yml` config will enable the upcoming V2 rule form: ```yaml xpack.trigger_actions_ui.enableExperimental: ['ruleFormV2'] xpack.infra.featureFlags.ruleFormV2Enabled: true xpack.ml.experimental.ruleFormV2.enabled: true xpack.transform.experimental.ruleFormV2Enabled: true xpack.legacy_uptime.experimental.ruleFormV2Enabled: true xpack.observability.unsafe.ruleFormV2.enabled: true xpack.slo.experimental.ruleFormV2.enabled: true xpack.apm.featureFlags.ruleFormV2Enabled: true discover.experimental.ruleFormV2Enabled: true ``` **These feature flags will not enable anything yet.** This PR is for the sole purpose of adding these browser-enabled flags now, so that we can reduce the amount of code committed later. ### Why feature flag every plugin? The V1 rule form is currently exported from Triggers Actions UI. In V2, we're moving away from this model and exporting the rule form in a KBN package. Therefore we can't simply export the results of a single feature flag from Triggers Actions UI, we need to signal to each individual plugin whether it should be pulling from the new KBN package or from the old cross-plugin export. ### Plugins affected #### Triggers Actions UI, Infra, Observability, APM These plugins already contained interfaces for experimental features or feature flags, so this PR simply adds a new flag to these existing structures. #### Discover, ML, Transform, Uptime, SLO These plugins did **not** have existing browser-exposed feature flag systems, so this PR adds these interfaces. The transform plugin notably did not yet have any config options configured at all.
This was referenced Apr 26, 2024
Closing as most of the tasks are done or tracked by #196235. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.14 candidate
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
This issue outlines the necessary steps to implement the full-page redesign of the Create Rule Flow.
Pre-production
Milestone 1: Bring rule form into page format from Management UI
Technical Debt
Milestone 2: Build on features
The text was updated successfully, but these errors were encountered: