Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] [Rule Form V2] Add rule type selection modal #179104

Closed
Tracked by #175634
Zacqary opened this issue Mar 20, 2024 · 0 comments · Fixed by #179285
Closed
Tracked by #175634

[RAM] [Rule Form V2] Add rule type selection modal #179104

Zacqary opened this issue Mar 20, 2024 · 0 comments · Fixed by #179285
Assignees
@Zacqary
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Mar 20, 2024 •
edited
Loading

Screenshot 2024-03-20 at 3 23 05 PM

This modal should be available from the Rules Management UI in both Stack and Observability.

Acceptance criteria

  • If the Rule Form V2 feature flag is disabled (or before [RAM] [Rule Form V2] Add full-page create/edit form #179105 is implemented), selecting a rule type should open the V1 flyout with that rule type selected
  • If Rule Form V2 is enabled, selecting a rule type should open the form with that rule type ready to go
@Zacqary Zacqary mentioned this issue Mar 20, 2024
Closed
12 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 20, 2024
@Zacqary Zacqary self-assigned this Mar 20, 2024
@Zacqary Zacqary added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX and removed needs-team Issues missing a team label labels Mar 20, 2024
@Zacqary Zacqary moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Rules & Alerts Management Mar 20, 2024
@Zacqary Zacqary mentioned this issue Mar 22, 2024
Merged
2 tasks
@Zacqary Zacqary moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Mar 25, 2024
Zacqary added a commit that referenced this issue Apr 3, 2024
@Zacqary @kibanamachine
[RAM] [Rule Form V2] Add new rule type selection modal (#179285)
658cbde 
## Summary

Closes #179104

### Stack Management Rules Page

https://github.com/elastic/kibana/assets/1445834/cd55830d-6c9b-422d-87b0-f449fe2e7a18

### Observability Rules Page
<img width="1616" alt="Screenshot 2024-03-22 at 1 52 18 PM"
src="https://github.com/elastic/kibana/assets/1445834/96239280-5f81-4c28-b34e-fa9ea2d8771c">

This adds the new Rule Type Flyout from the Create Rule Flow v2 project.
As of this PR, it simply replaces the rule type selection flow from the
existing v1 flyout, and opens the v1 flyout when the user selects a rule
type.

**This functionality works well enough with existing v1 code that I'm
comfortable *not* putting this modal behind a feature flag.** Future UI
additions for Create Rule v2, such as the full-page experience, will be
behind feature flags.

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM] [Rule Form V2] Add new rule type selection modal Zacqary/kibana
1 participant
@Zacqary