-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Deprecation Issue for Team: kibana-data-discovery, Found in file: discover_layout.scss #190888
Closed
Tracked by
#190345
Labels
chore
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Team:DataDiscovery
Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Comments
petrklapka
added
the
Team:DataDiscovery
Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
label
Aug 20, 2024
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
added
chore
loe:small
Small Level of Effort
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
labels
Aug 20, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 17, 2024
…3001) - Closes elastic#190890 - Closes elastic#190888 - Closes elastic#190889 - Closes elastic#190891 (cherry picked from commit bdac358)
kibanamachine
referenced
this issue
Sep 17, 2024
) (#193198) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Fix SASS mixed-declations deprecation warnings (#193001)](#193001) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T16:14:17Z","message":"[Discover] Fix SASS mixed-declations deprecation warnings (#193001)\n\n- Closes https://github.com/elastic/kibana/issues/190890\r\n- Closes https://github.com/elastic/kibana/issues/190888\r\n- Closes https://github.com/elastic/kibana/issues/190889\r\n- Closes https://github.com/elastic/kibana/issues/190891","sha":"bdac358b5eddb17fba1f2d2f76e777b28db361ff","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover] Fix SASS mixed-declations deprecation warnings","number":193001,"url":"https://github.com/elastic/kibana/pull/193001","mergeCommit":{"message":"[Discover] Fix SASS mixed-declations deprecation warnings (#193001)\n\n- Closes https://github.com/elastic/kibana/issues/190890\r\n- Closes https://github.com/elastic/kibana/issues/190888\r\n- Closes https://github.com/elastic/kibana/issues/190889\r\n- Closes https://github.com/elastic/kibana/issues/190891","sha":"bdac358b5eddb17fba1f2d2f76e777b28db361ff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193001","number":193001,"mergeCommit":{"message":"[Discover] Fix SASS mixed-declations deprecation warnings (#193001)\n\n- Closes https://github.com/elastic/kibana/issues/190890\r\n- Closes https://github.com/elastic/kibana/issues/190888\r\n- Closes https://github.com/elastic/kibana/issues/190889\r\n- Closes https://github.com/elastic/kibana/issues/190891","sha":"bdac358b5eddb17fba1f2d2f76e777b28db361ff"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
markov00
pushed a commit
to markov00/kibana
that referenced
this issue
Sep 18, 2024
…3001) - Closes elastic#190890 - Closes elastic#190888 - Closes elastic#190889 - Closes elastic#190891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Team:DataDiscovery
Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
DEPRECATION: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in
& {}
.The file below has one or more instances where CSS behavior will change unless
the declaration is moved above the nested rule. Line numbers for the declaration
along with the file and line numbers in which the nested rule appears are
shown below.
More info: https://sass-lang.com/d/mixed-decls
The text was updated successfully, but these errors were encountered: