Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Deprecation Issue for Team: kibana-presentation, Found in file: input_control_vis.scss #190897

Closed
Tracked by #190345
petrklapka opened this issue Aug 20, 2024 · 2 comments
Closed
Tracked by #190345

CSS Deprecation Issue for Team: kibana-presentation, Found in file: input_control_vis.scss #190897

petrklapka opened this issue Aug 20, 2024 · 2 comments
Assignees
@nreese
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@petrklapka
Copy link
Member

DEPRECATION: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless
the declaration is moved above the nested rule. Line numbers for the declaration
along with the file and line numbers in which the nested rule appears are
shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss

   ┌──> kibana/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
4  │     min-height: 0;
   │     ^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
31 │ ┌   &::-webkit-scrollbar-corner,
32 │ │   &::-webkit-scrollbar-track {
33 │ │     background-color: $trackBackgroundColor;
34 │ │   }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
5  │     flex: 1 1 0;
   │     ^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
31 │ ┌   &::-webkit-scrollbar-corner,
32 │ │   &::-webkit-scrollbar-track {
33 │ │     background-color: $trackBackgroundColor;
34 │ │   }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
6  │     display: flex;
   │     ^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
31 │ ┌   &::-webkit-scrollbar-corner,
32 │ │   &::-webkit-scrollbar-track {
33 │ │     background-color: $trackBackgroundColor;
34 │ │   }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/input_control_vis/public/components/vis/input_control_vis.scss
7  │     overflow: auto;
   │     ^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
31 │ ┌   &::-webkit-scrollbar-corner,
32 │ │   &::-webkit-scrollbar-track {
33 │ │     background-color: $trackBackgroundColor;
34 │ │   }
   │ └─── nested rule
   ╵
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 20, 2024
@petrklapka petrklapka added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 20, 2024
@petrklapka petrklapka mentioned this issue Aug 20, 2024
Closed
@ThomThomson ThomThomson added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 21, 2024
@nreese nreese mentioned this issue Oct 2, 2024
Merged
@nreese nreese self-assigned this Oct 2, 2024
nreese added a commit that referenced this issue Oct 4, 2024
@nreese @elasticmachine
[presentation team] Fix SASS mixed-declarations deprecation warnings (#…
6cf30e4 
…194721)

closes #190895,
#190896, and
#190897

## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

PR moves declarations above the nested rules.

Co-authored-by: Elastic Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 4, 2024
@nreese
[presentation team] Fix SASS mixed-declarations deprecation warnings (e…
9b96eaf 
…lastic#194721)

closes elastic#190895,
elastic#190896, and
elastic#190897

## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

PR moves declarations above the nested rules.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 6cf30e4)
@nreese
Copy link
Contributor

nreese commented Oct 4, 2024

closed by #194721

@nreese nreese closed this as completed Oct 4, 2024
jbudz pushed a commit to jbudz/kibana that referenced this issue Oct 4, 2024
@nreese @elasticmachine @jbudz
[presentation team] Fix SASS mixed-declarations deprecation warnings (e…
4398984 
…lastic#194721)

closes elastic#190895,
elastic#190896, and
elastic#190897

## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

PR moves declarations above the nested rules.

Co-authored-by: Elastic Machine <[email protected]>
kibanamachine added a commit that referenced this issue Oct 4, 2024
@kibanamachine @nreese
[8.x] [presentation team] Fix SASS mixed-declarations deprecation war…
bc44862 
…nings (#194721) (#195115)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[presentation team] Fix SASS mixed-declarations deprecation warnings
(#194721)](#194721)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T15:57:51Z","message":"[presentation
team] Fix SASS mixed-declarations deprecation warnings
(#194721)\n\ncloses
https://github.com/elastic/kibana/issues/190895,\r\nhttps://github.com/elastic/kibana/issues/190896,
and\r\nhttps://github.com//issues/190897\r\n\r\n##
Summary\r\n\r\n> Sass's behavior for declarations that appear after
nested\r\nrules will be changing to match the behavior specified by CSS
in an\r\nupcoming\r\nversion. To keep the existing behavior, move the
declaration above the\r\nnested\r\nrule. To opt into the new behavior,
wrap the declaration in & {}.\r\n\r\nPR moves declarations above the
nested rules.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"6cf30e4523dcada4174cfaaeb591eded2a8198ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[presentation
team] Fix SASS mixed-declarations deprecation
warnings","number":194721,"url":"https://github.com/elastic/kibana/pull/194721","mergeCommit":{"message":"[presentation
team] Fix SASS mixed-declarations deprecation warnings
(#194721)\n\ncloses
https://github.com/elastic/kibana/issues/190895,\r\nhttps://github.com/elastic/kibana/issues/190896,
and\r\nhttps://github.com//issues/190897\r\n\r\n##
Summary\r\n\r\n> Sass's behavior for declarations that appear after
nested\r\nrules will be changing to match the behavior specified by CSS
in an\r\nupcoming\r\nversion. To keep the existing behavior, move the
declaration above the\r\nnested\r\nrule. To opt into the new behavior,
wrap the declaration in & {}.\r\n\r\nPR moves declarations above the
nested rules.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"6cf30e4523dcada4174cfaaeb591eded2a8198ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194721","number":194721,"mergeCommit":{"message":"[presentation
team] Fix SASS mixed-declarations deprecation warnings
(#194721)\n\ncloses
https://github.com/elastic/kibana/issues/190895,\r\nhttps://github.com/elastic/kibana/issues/190896,
and\r\nhttps://github.com//issues/190897\r\n\r\n##
Summary\r\n\r\n> Sass's behavior for declarations that appear after
nested\r\nrules will be changing to match the behavior specified by CSS
in an\r\nupcoming\r\nversion. To keep the existing behavior, move the
declaration above the\r\nnested\r\nrule. To opt into the new behavior,
wrap the declaration in & {}.\r\n\r\nPR moves declarations above the
nested rules.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"6cf30e4523dcada4174cfaaeb591eded2a8198ee"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@nreese @elasticmachine @tiansivive
[presentation team] Fix SASS mixed-declarations deprecation warnings (e…
c2bcbe0 
…lastic#194721)

closes elastic#190895,
elastic#190896, and
elastic#190897

## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

PR moves declarations above the nested rules.

Co-authored-by: Elastic Machine <[email protected]>
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@nreese @elasticmachine @tiansivive
[presentation team] Fix SASS mixed-declarations deprecation warnings (e…
477228a 
…lastic#194721)

closes elastic#190895,
elastic#190896, and
elastic#190897

## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

PR moves declarations above the nested rules.

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @ThomThomson @elasticmachine @petrklapka