Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Deprecation Issue for Team: kibana-security, Found in file: spaces_menu.scss #190904

Closed
Tracked by #190345
petrklapka opened this issue Aug 20, 2024 · 1 comment · Fixed by #193931
Closed
Tracked by #190345

CSS Deprecation Issue for Team: kibana-security, Found in file: spaces_menu.scss #190904

petrklapka opened this issue Aug 20, 2024 · 1 comment · Fixed by #193931
Assignees
Labels
chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@petrklapka
Copy link
Member

DEPRECATION: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless
the declaration is moved above the nested rule. Line numbers for the declaration
along with the file and line numbers in which the nested rule appears are
shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.scss

   ┌──> kibana/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.scss
8  │     max-height: $euiSizeXL * 10;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 20, 2024
@petrklapka petrklapka added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 20, 2024
@legrego legrego added the chore label Sep 6, 2024
@kc13greiner kc13greiner self-assigned this Sep 12, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 1, 2024
## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

I have moved the declarations above the nested rules.

I had attempted to opt in to the new behavior, but the resulting CSS has
duplicate selectors, which CI does not allow

For more information about the new behavior, see
[here](https://sass-lang.com/documentation/breaking-changes/mixed-decls/)

Closes elastic#190898
[screenshots](elastic#193931 (comment))
Closes elastic#190899
[screenshots](elastic#193931 (comment))
Closes elastic#190900 Access Page uses
`authentication_state_page`, but I was unable to find
'overwrite_session` and `logged_out` pages
Closes elastic#190901
[screenshots](elastic#193931 (comment))
Closes elastic#190902 ^used on same UI
Closes elastic#190903
[screenshots](elastic#193931 (comment))
Closes elastic#190904
[screenshots](elastic#193931 (comment))

(cherry picked from commit c8c7439)
seanrathier pushed a commit to seanrathier/kibana that referenced this issue Oct 2, 2024
## Summary

> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.

I have moved the declarations above the nested rules.

I had attempted to opt in to the new behavior, but the resulting CSS has
duplicate selectors, which CI does not allow

For more information about the new behavior, see
[here](https://sass-lang.com/documentation/breaking-changes/mixed-decls/)

Closes elastic#190898
[screenshots](elastic#193931 (comment))
Closes elastic#190899
[screenshots](elastic#193931 (comment))
Closes elastic#190900 Access Page uses
`authentication_state_page`, but I was unable to find
'overwrite_session` and `logged_out` pages
Closes elastic#190901
[screenshots](elastic#193931 (comment))
Closes elastic#190902 ^used on same UI
Closes elastic#190903
[screenshots](elastic#193931 (comment))
Closes elastic#190904
[screenshots](elastic#193931 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants