Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta] Replace vislib #56143

Closed
flash1293 opened this issue Jan 28, 2020 · 2 comments
Closed

[Meta] Replace vislib #56143

flash1293 opened this issue Jan 28, 2020 · 2 comments
Labels
Feature:Vislib Vislib chart implementation Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jan 28, 2020 •
edited by stratoula
Loading

Summary:

The current chart types located in src/plugins/vis_type_vislib based on the legacy vislib chart implementation should incrementally be replaced by the elastic-charts chart library.

The resulting rendering should be compatible with the current charts. Breaking changes will be added to 8.0.0 to implement more functionality (e.g. fitting functions) and gracefully handle and enforce best practices (e.g. forbid stacked line charts).

The visTypeXy.enabled kibana.yml config flag can be enabled to switch between vislib and elastic-charts rendering while vislib is incrementally replaced the without using long-lived feature branch.

Tacking in elastic charts: elastic/elastic-charts#66

Pending feature parity issues

Sunset features for 8.0.0:

  • Stacked line charts

Sub tasks:

chart type status PR
Line ✅ #78154
Area ✅ #78154
Histogram/VerticalBar ✅ #78154
HorizontalBar ✅ #78154
Pie ✅ #83929
Heatmap
Gauge
Goal
@flash1293 flash1293 added Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@markov00 markov00 mentioned this issue Feb 3, 2020
Closed
27 tasks
@timroes timroes added the Feature:Vislib Vislib chart implementation label Mar 27, 2020
@nickofthyme nickofthyme linked a pull request Jun 17, 2020 that will close this issue
Replace line, area and bar charts with elastic charts #57584
Closed
23 tasks
@timroes timroes mentioned this issue Oct 30, 2020
Closed
@timroes timroes mentioned this issue Nov 24, 2020
Closed
@stratoula stratoula mentioned this issue Dec 2, 2020
Closed
3 tasks
@timroes timroes mentioned this issue Dec 14, 2020
Closed
@stratoula stratoula mentioned this issue Dec 22, 2020
Merged
7 tasks
@mbondyra mbondyra mentioned this issue Nov 17, 2021
Closed
@stratoula
Copy link
Contributor

This is done! The only thing remaining is to remove the vlisb implementations of heatmap and gauge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Vislib Vislib chart implementation Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace line, area and bar charts with elastic charts nickofthyme/kibana
4 participants
@timroes @flash1293 @elasticmachine @stratoula