Replace line, area and bar charts with elastic charts #57584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
Feature:Vislib
Closed
nickofthyme
force-pushed
the
kpm/new-line-chart
branch
from
053f2c4
to
7fc596b
Compare
22 tasks
Closed
nickofthyme
changed the title
3 tasks
nickofthyme
force-pushed
the
kpm/new-line-chart
branch
from
7fc596b
to
2155b11
Compare
nickofthyme
force-pushed
the
kpm/new-line-chart
branch
from
2155b11
to
92a747a
Compare
- move editor config components from vislib to xy plugin - import editor values from xy to vislib - move vislib type definitions to xy plugin and reference from vislib - refactor types to be consistent with elastic-charts
- add toExpression method on visType - move vislib expression build into vislib plugin - update vis types for toExpressionAst method
- add color picker component - remove unused methods from MappedColors class - add legend toggle component - add elastic charts click transforms for filter and brush events
nickofthyme
force-pushed
the
kpm/new-line-chart
branch
from
92a747a
to
41723e8
Compare
💔 Build Failed
Failed CI StepsBuild metricsHistory
To update your PR or re-run it, just comment with: |
|
Closed in favor of #78154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace vislib line chart with elastic charts.
elastic/elastic-charts#66
Remaining tasks
Release strategy
This PR is near feature parity with existing vislib with the exception of small multiples (elastic/elastic-charts#500) and stack offsets (elastic/elastic-charts#715).
The current plan is to merge without waiting for these two features and backport into
7.10. A separate PR will be used to enable the plugin inmaster.A follow-up PR will add the small multiples and stack offsets features when ready. If all are features are ready by
7.10and no bugs are outstanding the plugin will be enabled in7.10release.Checklist
Delete any items that are not applicable to this PR.
For maintainers