[Fleet] Make agent Policy input id unique #83101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
💔 Build Failed
Failed CI StepsTest FailuresX-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_details·ts.endpoint When on the Endpoint Policy Details Page and the save button is clicked should display success toast on successful saveStandard OutStack TraceX-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_details·ts.endpoint When on the Endpoint Policy Details Page and the save button is clicked should display success toast on successful saveStandard OutStack TraceMetrics [docs]Distributable file count
Page load bundle
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
|
This change will have impacts to Endpoint in Kibana and possibly also the actual Endpoint (maybe not). I don't believe Endpoint uses the ID for any processing, but @ferullo can confirm. There may also be some impacts to our APIs which use the Fleet services to query for data - @pzl and/or @nnamdifrankie can confirm. @nchaulet : Any chance this could be done by having the Elastic Agent instead build the id based on |
|
@paul-tavares Assuming you are referring to the configuration item |
The uuid is unique for a package policy (by integration) but a package policy could have multiple inputs (most of integration have two one for log, one for metrics), so we need to differentiate them |
|
Thanks @nchaulet . I see what you mean (for endpoint, we currently don't support multiples - only one). |
|
I'm thinking a little more about this - @nchaulet do you happen to have a full Agent Policy YAML with Endpoint that you can post here? |
|
Yes sure |
|
Thanks @nchaulet . I reconfirmed our impacts in Kibana that I previously highlighted |
|
@paul-tavares do you see a way we can fix endpoint, and have unique input ids? |
|
@paul-tavares @nchaulet , some thoughts here. I'm seeing a few paths forward.
|
|
@kevinlog I am not sure keeping the prefix + id is completely future proof, I am wondering if the better solution here is to allow you to search a package policy for a input Id when you need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #82426
In the effort to have better agent observability and status per input, we need to have unique id per input. (this will probably help with the future Fleet server data model too)
This PR change input ids to be unique.
Details
Input ids are now build like this
${input.type}-${packagePolicyId}This give the following config for example
This a breaking change as
packagePolicyIdis no longer equal toinputId@kevinlog This require change in the endpoint app