[Discover] Hide multi fields in Doc Viewer #101929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
changed the title
kertal
reviewed
Jun 14, 2021
|
Good point actually. |
majagrubic
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
reviewed
Jun 15, 2021
Comment on lines
203
to
209
| [SHOW_MULTIFIELDS]: { | ||
| name: i18n.translate('discover.advancedSettings.discover.showMultifields', { | ||
| defaultMessage: 'Show multi fields', | ||
| }), | ||
| description: i18n.translate('discover.advancedSettings.discover.showMultifieldsDescription', { | ||
| defaultMessage: `When enabled will show multi fields in document viewer. In majority of cases, multi-fields are the same as regular fields. This option is only available when searchFieldsFromSource is off. `, | ||
| }), |
There was a problem hiding this comment.
FYI dear @gchaps a new config flag and wording
There was a problem hiding this comment.
Adding a screenshot to make things more clear:
There was a problem hiding this comment.
Here is a suggestion
Show multi-fields
Controls whether multi-fields display in the document table. Available when searchFieldsFromSource is off.
Notes:
- multi-fields has a hyphen
- Not sure what the document viewer is. Does it refer to the document table?
- Is the second sentence needed? Not sure what "regular field" means.
There was a problem hiding this comment.
Document viewer is the part in the expanded view of the document table that shows all fields in the document:
Please note that multifield values will always show up in the document table. This PR introduces changes in the doc viewer specifically.
As for the second sentence, I am open to suggestions on how to improve it. I would like to keep the emphasis on the fact that in 99% of cases, there should be no difference between an original field value and its multi-field counterpart.
There was a problem hiding this comment.
Show multi-fields
Controls whether multi-fields display in the expanded document view. In most cases, multi-fields are the same as the original field. This option is only available when searchFieldsFromSource is off.
kertal
reviewed
Jun 15, 2021
| @@ -26,6 +28,7 @@ export function DocViewTable({ | |||
| const [fieldRowOpen, setFieldRowOpen] = useState({} as Record<string, boolean>); | |||
| const [multiFields, setMultiFields] = useState({} as Record<string, string[]>); | |||
| const [fieldsWithParents, setFieldsWithParents] = useState([] as string[]); | |||
| const showMultiFields = getServices().uiSettings.get(SHOW_MULTIFIELDS); | |||
There was a problem hiding this comment.
quick first thought while reading the code, since the value of SHOW_MULTIFIELDS is read and used in table.tsx, I wonder if it is necessary to add this field to html templates and Angular code?
|
@elasticmachine merge upstream |
Bamieh
approved these changes
Jun 16, 2021
kertal
approved these changes
Jun 16, 2021
src/plugins/discover/public/application/angular/doc_table/doc_table.ts
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/angular/doc_table/doc_table.ts
Outdated
Show resolved
Hide resolved
|
jenkins, test this (restarting due to jenkins upgrade) |
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jun 17, 2021
* Add multifields flag in the Advanced settings * Implement hiding of multifields * Update failing unit test * Fix telemetry * Show muti fields in a single doc view * Mock getServices so that tests pass * Readd fields to sidebar * Removing showMultifields flag from angular * Remove unnecessary import * Applying text changes according to Gails suggestion * Fix i18n error Co-authored-by: Kibana Machine <[email protected]>
majagrubic
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Add multifields flag in the Advanced settings * Implement hiding of multifields * Update failing unit test * Fix telemetry * Show muti fields in a single doc view * Mock getServices so that tests pass * Readd fields to sidebar * Removing showMultifields flag from angular * Remove unnecessary import * Applying text changes according to Gails suggestion * Fix i18n error Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/close_jobs·ts.apis Machine Learning jobs close_jobs close jobs fail because they are running as ML PoweruserStandard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/close_jobs·ts.apis Machine Learning jobs close_jobs close jobs fail because they are running as ML PoweruserStandard OutStack TraceMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: #96029
This PR adds a switch in the UI settings (
discover:showMultiFields), determining whether to show or hide multifields in Discover. The default value isfalse, as we assume the majority of users will not need them to be visible by default. Note: this setting will toggle multifields from the doc viewer. They will still be visible in the doc table (and datagrid), the sidebar, as well as in the JSON view.Doc viewer without multifields:
Doc viewer with multifields:
Doc table always:
We should add some more documentation around it still.
Checklist